Hi Liming,

Thank you for your feedback. Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 07/07/2022 02:51 am, gaoliming wrote:
>
> Sami:
>
>  I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can 
> be EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been 
> updated, such as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.
>
[SAMI] Ack. I will change this in the next patch series.
>
>  Compared to the previous version, EFI_ACPI_6_0_IO_REMAPPING_RC_NODE 
> struct is larger. Does this change bring any impact?
>
[SAMI] The EFI_ACPI_6_0_IO_REMAPPING_NODE.Length field should reflect 
the increased size. Similarly, the Revision field in the IORT ACPI table 
header and the EFI_ACPI_6_0_IO_REMAPPING_NODE.Revision field would also 
be updated accordingly. Therefore, an OS should be able to detect the 
change and handle accordinlgy.

As for existing firmware code that does not make use of the latest IORT 
revision, I have an edk2-platforms patch series that fixes the IORT 
Table revision to EFI_ACPI_IO_REMAPPING_TABLE_REV0, see 
https://edk2.groups.io/g/devel/message/91104.

[/SAMI]

>
> Thanks
>
> Liming
>
> *发件人:*devel@edk2.groups.io <devel@edk2.groups.io> *代表 *Sami Mujawar
> *发送时间:*2022年7月6日23:44
> *收件人:*Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
> *主题:*Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for 
> IORT Rev E.d spec
>
> On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:
>
>     -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0
>     +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
>     +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5
>
> Based on discussion at 
> https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D1657101454237486469&previd=1657121904386162709&nextid=1657101454237486469, 
> <https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D1657101454237486469&previd=1657121904386162709&nextid=1657101454237486469,> 
> the suggestion is to rename these macros to 
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 and 
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 respectively.
> I will wait for any other feedback on this series, before I send out 
> the updated series reflecting the macro renaming.
>
> Regards,
>
> Sami Mujawar
>
> 
>