From: "wang xiaofeng" <winggundum82@163.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Fan, Jeff" <jeff.fan@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
Date: Wed, 24 Aug 2016 12:27:30 +0800 (CST) [thread overview]
Message-ID: <71984347.301a.156bacd94ec.Coremail.winggundum82@163.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com>
Jiewen,
Thanks for the information.
At 2016-08-24 11:56:48, "Yao, Jiewen" <jiewen.yao@intel.com> wrote:
>Hi
>That is done by design. We just need save the *pointer* to variable region, not the *content*.
>The content is in EfiReservedMemoryType memory.
>
>An OS application can get this pointer and parse the data pointed by mSmmProfileBase
>
>Thank you
>Yao Jiewen
>
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of wang xiaofeng
>Sent: Wednesday, August 24, 2016 11:43 AM
>To: Fan, Jeff <jeff.fan@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: [edk2] incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
>
>Hi Jeff,
> Not sure whether you owns SmmProfile.c. I found the following logic is incorrect.
> sizeof(mSmmProfileBase) is 8, we should use sizeof(SMM_PROFILE_HEADER). Otherwise the variable size is incorrect
>
>
>| gRT->SetVariable ( |
>| | SMM_PROFILE_NAME, |
>| | &gEfiCallerIdGuid, |
>| | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, |
>| | sizeof(mSmmProfileBase), |
>| | &mSmmProfileBase |
>| |
>);
>
>
>
>
>
>
>
>
>
>
>
>
>|
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-08-24 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <686725847.17974924.1471378566839.JavaMail.yahoo.ref@mail.yahoo.com>
2016-08-16 20:16 ` Do BSPs only have to be logical thread 0 ? Shubha Ramani
2016-08-23 3:04 ` Fan, Jeff
2016-08-24 3:43 ` incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c wang xiaofeng
[not found] ` <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com>
2016-08-24 4:27 ` wang xiaofeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71984347.301a.156bacd94ec.Coremail.winggundum82@163.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox