From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.533.1617756301412352180 for ; Tue, 06 Apr 2021 17:45:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Cq0xCQ7+; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1370WhqO129351; Tue, 6 Apr 2021 20:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=T92LMU2dYdgwW86X/VjY0a5zduaKzuhNIATJ4w4zc2U=; b=Cq0xCQ7+b+qtiJnB6HpaPiK7W1sfvyDdt/ot/m/XK8UQZKv7pxPNh4JKMEhDJ8Nad49p RhCe2zlbNC/gONErGg1IeCM2coQOWth7135yIjF0nuZTq65JjBaGpFHiiHj/RWqLN0X1 EAsDmxtBFhhfp/IZJ7qkPNgXOykbbpXQCpbLRWmPIg7VTQOnYswfYeUwGLdsHzSeE4pE lRY56xdosvHlrFgloF5bESAijO4b/+9d/ocUA5xOB4ObxKWaERoZts85Xq2vK/lHIIEj 7XyLR8/jethwEl9Le0aeZDxqKNHENxm8JE0PdTHSi6fpPXKAsJBkANAMVZosWrDQk/tV Bw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 37rvmq0net-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 20:44:58 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1370WjAd129451; Tue, 6 Apr 2021 20:44:58 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com with ESMTP id 37rvmq0neh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 20:44:58 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 1370XQ0w024290; Wed, 7 Apr 2021 00:44:57 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma03wdc.us.ibm.com with ESMTP id 37rvc422k0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Apr 2021 00:44:57 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1370iugk11010404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Apr 2021 00:44:56 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B02578060; Wed, 7 Apr 2021 00:44:56 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7A4857805F; Wed, 7 Apr 2021 00:44:54 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.189.52]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 7 Apr 2021 00:44:54 +0000 (GMT) Message-ID: <719a63e555376ca65a7bbe0c7e23c20b6b631cd3.camel@linux.ibm.com> Subject: Re: [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: "Xu, Min M" , Laszlo Ersek , Brijesh Singh , "devel@edk2.groups.io" Cc: "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel Date: Tue, 06 Apr 2021 17:44:52 -0700 In-Reply-To: References: <20210324153215.17971-1-brijesh.singh@amd.com> <20210324153215.17971-2-brijesh.singh@amd.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: yp0jytw4rshP2S-OyTwq5IVF01l_m4eo X-Proofpoint-ORIG-GUID: Jh6Fc56SX-Jr7EB-QtBT4n-aNnh4l9ys X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-04-06_09:2021-04-06,2021-04-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 mlxscore=0 clxscore=1015 impostorscore=0 mlxlogscore=926 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104070001 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2021-04-07 at 00:21 +0000, Xu, Min M wrote: > Hi, Laszlo > > For Intel TDX supported guest, all processors start in 32-bit > protected > mode, while for Non-Td guest, it starts in 16-bit real mode. To make > the > ResetVector work on both Td-guest and Non-Td guest, ResetVector are > updated as below: > ------------------------------------------------------------------ > ALIGN 16 > resetVector: > ; > ; Reset Vector > ; > ; This is where the processor will begin execution > ; > nop > nop > smsw ax > test al, 1 > jnz EarlyBspPmEntry > jmp EarlyBspInitReal16 Well, then use the rel8 jump like the compiler would in this situation: smsw ax test al, 1 jz 1f jmp EarlyBspPmEntry 1: jmp EarlyBspInitReal16 So now both entries can be 32k away. James