From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.1706.1610702946801854036 for ; Fri, 15 Jan 2021 01:29:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hps2UIpW; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610702946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0q/jaAbPOovty31/vnKz6Tdk/cMcnABlVzgsn/hBU/E=; b=Hps2UIpW4T3T/xugCCsSnhkEVEVqB16LmbyIA8+lMnRVBn6ERTBx9772uqHKwgDGffcInG BxoEYaJU6imZgUcAyK7EUOs7vZg3RzgmVXk9zySxjGdqhc/xZu2U4fLugSfevoX3eZOlkg 1ALvtrPkEuggWmTs5EnNADFQBm9o3pM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-i-3DWRR3PmyylZU5Z1ZFlA-1; Fri, 15 Jan 2021 04:29:02 -0500 X-MC-Unique: i-3DWRR3PmyylZU5Z1ZFlA-1 Received: by mail-ej1-f72.google.com with SMTP id q11so3375965ejd.0 for ; Fri, 15 Jan 2021 01:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0q/jaAbPOovty31/vnKz6Tdk/cMcnABlVzgsn/hBU/E=; b=ROI4TGg70+rrqdqiB7sS87IyVD8g0Tz853h8V0msTu31eEQSA+IyzzuxoB19osVUdX T0Mse4WSVILN7y9RgnfjcM/rW1yZXp+Sqd1ZRGfzd7hpzTmoigmH3eehi8GiaIgSGKSx lB9+h7XnZms+p7JIt9IbPrDVfe5M+ypjZ8541eB8hc82FuGECh8BPf9yhGY/VaqQoatM DBjvmfCTGeAO4mP4RncrjWa5PV0CubSJzuEGjlQgmLiuaLFb8YqzqtA4fQYZ4U5WYn/7 6KCQLNl974K+TeLBi3IAD87yNSrmNZUrWAIcyeV52V7naIq8jgLYFyeVYF5fr7xYrWgB oCKQ== X-Gm-Message-State: AOAM530fpUMIaquEH7jGFOpkGxd0mIym1tdtlRFfQgCg+j91AWY6WHDd fJHKnrr3dQq4Yq1gT2eQJlJsYbxX/uBMvtC8OknaAZoz80lL1/rlMFWbhZvYVrCI09nOopQlM6b b8L90x3Y3RsEyaw== X-Received: by 2002:a50:fc8b:: with SMTP id f11mr8852360edq.11.1610702941541; Fri, 15 Jan 2021 01:29:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJywO47sKVcbMbVjSQiYibeocPjHNc8gFINNq+bqUw8kJXy+1cjPBg1fb1Fl5y0+2QNX8+w8+Q== X-Received: by 2002:a50:fc8b:: with SMTP id f11mr8852346edq.11.1610702941417; Fri, 15 Jan 2021 01:29:01 -0800 (PST) Return-Path: Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id c16sm3015337ejk.91.2021.01.15.01.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 01:29:00 -0800 (PST) Subject: Re: [PATCH 1/3] UefiCpuPkg/AcpiCpuData: update comments on register table fields To: Laszlo Ersek , devel@edk2.groups.io Cc: Eric Dong , Rahul Kumar , Ray Ni , Star Zeng References: <20210112191934.12459-1-lersek@redhat.com> <20210112191934.12459-2-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <719de765-ba4c-6737-ab15-2b8f238e5470@redhat.com> Date: Fri, 15 Jan 2021 10:28:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112191934.12459-2-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 1/12/21 8:19 PM, Laszlo Ersek wrote: > After commit e992cc3f4859 ("UefiCpuPkg PiSmmCpuDxeSmm: Reduce SMRAM > consumption in CpuS3.c", 2021-01-11), it is valid for a CPU S3 Data DXE > Driver to set "ACPI_CPU_DATA.PreSmmInitRegisterTable" and/or > "ACPI_CPU_DATA.RegisterTable" to 0, in case none of the CPUs needs a > register table of the corresponding kind, during S3 resume. > > Document this fact in the "UefiCpuPkg/Include/AcpiCpuData.h" header file. > > Cc: Eric Dong > Cc: Philippe Mathieu-Daudé > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Star Zeng > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3159 > Signed-off-by: Laszlo Ersek > --- > UefiCpuPkg/Include/AcpiCpuData.h | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daude