From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 02:33:31 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3040C007359; Tue, 30 Jul 2019 09:33:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30CBB60BE5; Tue, 30 Jul 2019 09:33:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Julien Grall , xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-7-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: <71b514aa-f54f-b262-e544-7a1c46a1dbf9@redhat.com> Date: Tue, 30 Jul 2019 11:33:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729153944.24239-7-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 30 Jul 2019 09:33:30 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/29/19 17:39, Anthony PERARD wrote: > Add a new entry point for Xen PVH that enter directly in 32bits. > > Information on the expected state of the machine when this entry point > is used can be found at: > https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > > Also, compare to the original file [1], the two `nop' of the "resetVector" > entry point are removed. There were introduced by 8332983e2e33 > ("UefiCpuPkg: Replace the un-necessary WBINVD instruction at the reset > vector with two NOPs in VTF0.", 2011-08-04), but don't seems to be > useful. This is the entry point used by HVM guest (hvmloader). > > [1] UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > > Notes: > v4: > - remove the two nop in the HVM entry point Also, new paragraph in the commit message. Acked-by: Laszlo Ersek