From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.9161.1679693253649411226
 for <devel@edk2.groups.io>;
 Fri, 24 Mar 2023 14:27:33 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=BCZF9ioH;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 4B86820FC45C;
	Fri, 24 Mar 2023 14:27:32 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4B86820FC45C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1679693253;
	bh=LC3Q5By4ylFjRw3KXfnQdp/q6nhHvrii9RSgeOqy2DQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=BCZF9ioHQ5JuaR+P52cesZmet1e/uX51LnBp5kx+sul2G7MvR0gDupDunFkVw5elf
	 OBK/cia5qCfgOOOC9dJFI6/MLvBJG2eQI3FME+YhkyyvlxrlG3EMxO+RVfYPAfh62e
	 mDGEWEQVMQ1crpdDhkGAA8YtbZzMa2ro9hbTeRTE=
Message-ID: <71c0f0e1-2e22-0531-d036-b70d6fa94f88@linux.microsoft.com>
Date: Fri, 24 Mar 2023 17:27:31 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [edk2-devel] [PATCH v6 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>, Yuwei Chen <yuwei.chen@intel.com>
References: <20230324204838.1485-1-mikuback@linux.microsoft.com>
 <20230324204838.1485-3-mikuback@linux.microsoft.com>
 <174F7634AC74F535.7603@groups.io>
 <5ec2b49b-c6a7-df8e-66fe-900598422c1d@bsdio.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <5ec2b49b-c6a7-df8e-66fe-900598422c1d@bsdio.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Yes, no problem. Thanks for bringing this to my attention.

On 3/24/2023 4:56 PM, Rebecca Cran wrote:
> Ah, but my patch was only for Makefiles: I didn't realize source files 
> also contain tabs.
> 
> So we probably want a combination of our patches: yours to ignore the 
> entire directory, and the change I made to also ignore files named 
> "makefile" as well as "Makefile".
> 
> Could you update your patch with my 
> "os.path.basename(self.filename).lower() == 'makefile' " change please?
> 
>