From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 87CB1223FCF53 for ; Thu, 15 Mar 2018 02:21:54 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id i194so9033409wmg.1 for ; Thu, 15 Mar 2018 02:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dOucYsmukAkG4nxwfEGJrHqThKiSwDyuE/3GVikL0lU=; b=lKnUv12t1rHUQtXYj7Rz7+lSkU+Gp+SpLLRnmc/jpmHhmD3DjAoeO5RNqPIeVi5Nei mrEXfykDDhWBDvAVeA1dO85wDYkH0bkKZ4LbTTXW1SRafxpFJdg+qbQ561MVwS63SRQk 1DLLdmMj97dZVI0NkHLL1riFu6jQGasLvs2rkIFZUWjrOvxyPX0I+BMvJ1xOTKNJOXFc rXSvGkjthlsno6SoMGyoKkN4Wh+SDFoHqRgCQ74NA5U7Un/c6P1ePYMPLYS2qiB3m1sr K8kkpsisus15TeJVo1BLAGQNOXJhZ3D/XsMopQmOtDEc/pHjuPg60iW6f7TNa+es95bP KnLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dOucYsmukAkG4nxwfEGJrHqThKiSwDyuE/3GVikL0lU=; b=ShGkEsaPutaHiLIwVDcXp51WkXkavRkp/oz6ffGhQzCPP2vkw9Omvm0FjsSWwhfBKd f2aVMa+GuhZDbsRnLDjgajL2V83d0pHrRJumdUwHbJFJVkh3Pg7DxLH4Lgyhfxbxp/Cq 5s0T/1cc3jSz2QcWJHfLpCE6BCL2qjuhwRm4Evk4RF1Fcp2+cXXZrZx5GdnXCL545g1t RB2qSGNwiWZiqwuJ3AW7nhlo1QHkmPiBSzFqUJX7nPbgy80TY+pwo3CHCgtwGcvvt/gK MqVO0SzGgHRn0xhz2W//EbQzeE/zRV6pIl9z+rWNxbMXBQCJgVi+ZDuhdN+6cLfJ9s5c oWQw== X-Gm-Message-State: AElRT7HK/6wcOfoaWXZGWs53EHZwg0I6VfOh6cVCvibY4sproM8S1Nh4 PmftGjm3NPUwLpJklD2Wdcixkg== X-Google-Smtp-Source: AG47ELst4McADMG/twKVCUsn6Q+epRGbkE5HzLJG6yXCCXDiuMGR/n4Fi6Il6C2wRURmwzrGZcFpuQ== X-Received: by 10.80.134.227 with SMTP id 32mr2598472edu.177.1521106096213; Thu, 15 Mar 2018 02:28:16 -0700 (PDT) Received: from [10.0.0.101] ([84.203.92.234]) by smtp.googlemail.com with ESMTPSA id r48sm2345620edd.74.2018.03.15.02.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 02:28:15 -0700 (PDT) To: "Gao, Liming" , "edk2-devel@lists.01.org" Cc: "ard.biesheuvel@linaro.org" References: <20180223095003.6012-1-pete@akeo.ie> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E7104@SHSMSX104.ccr.corp.intel.com> From: Pete Batard Message-ID: <71d6b134-d875-2c24-6687-f3b01d0ff9ea@akeo.ie> Date: Thu, 15 Mar 2018 09:28:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E7104@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH 0/4] Add ARM64 support for VS2017 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 09:21:55 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Liming, Thanks for reviewing the patches. On 2018.03.15 06:15, Gao, Liming wrote: > Pete: > For new added ASM file in BaseLib, could you use the same comment style > for them? ASM use ; for the comment. Most of new files uses ; as the > comment, but switchstack is not. This is because SwitchStack.asm is simply SwitchStack.S, with the GCC assembler specifics removed, and MSVC assembler specifics added. I did not change the comment style from the original files, so the real issue here is that our GCC assembly files for AARCH64 do not use the same comment style. I'm fine with trying to harmonize the comment styles, but seeing as this needs to be done for both the .S and .asm, I'd rather send a patch to do that *after* these VS2017 changes have been applied, as I don't consider this correction to in scope of this patch series (because logically, the introduction of VS2017 should not alter any of the .S files, unless we reuse them, which we don't). If you agree to apply this series, I'll make sure to send a non VS2017-specific additional patch, that does what you request for both the .S and .asm. > Besides, compared to Arm arch assembly > file, I don't find CpuPause.asm. Is it required? That file doesn't exist for GCC (as you will see there is no MdePkg/Library/BaseLib/AArch64/CpuPause.S), so we don't have one for VS2017 either. Regards, /Pete