From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.10140.1586442998979825543
 for <devel@edk2.groups.io>;
 Thu, 09 Apr 2020 07:36:39 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E63F830E;
	Thu,  9 Apr 2020 07:36:37 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B8E3C3F68F;
	Thu,  9 Apr 2020 07:36:31 -0700 (PDT)
Subject: Re: [PATCH 1/1] ArmVirtPkg: Include NVMe support in ArmVirtQemu*
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
 Leendert van Doorn <leendert@microsoft.com>
References: <20200409121050.15387-1-leif@nuviainc.com>
 <27590721-972f-7d2f-d5d9-d8c8a77d0199@arm.com> <20200409143100.GB14075@vanye>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <71ef41ff-1c99-5b6b-c1f5-953b43d8fe2f@arm.com>
Date: Thu, 9 Apr 2020 16:36:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200409143100.GB14075@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/9/20 4:31 PM, Leif Lindholm wrote:
> On Thu, Apr 09, 2020 at 15:07:30 +0200, Ard Biesheuvel wrote:
>> On 4/9/20 2:10 PM, Leif Lindholm wrote:
>>> From: Leendert van Doorn <leendert@microsoft.com>
>>>
>>> Enable conditional support for NVMe storage in ArmVirtQemu/
>>> QemVirtQemuKernel in order to simplify booting/installing operating
>>> systems that don't support virtio.
>>>
>>> [Conditionalised driver inclusion]
>>
>> Why?
> 
> Well, it adds size and complexity for a target most frequently used to
> model a pure virtual environment?
> 
> Size difference isn't huge though:
> FVMAIN [99%Full] 5337920 total, 5337864 used, 56 free
> FVMAIN_COMPACT [39%Full] 2093056 total, 829392 used, 1263664 free
> vs.
> FVMAIN [99%Full] 5300992 total, 5300936 used, 56 free
> FVMAIN_COMPACT [38%Full] 2093056 total, 804128 used, 1288928 free
> 
> If that's not an issue, I'm happy to drop it and my bracketing.
> 

I agree that in general, driver stacks like network or TPM should be 
opt-in, but given the reason you are adding this [compatibility with 
other OSes], I'd prefer to have this one always built in.