public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: rebecca@bsdio.com
To: devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: lersek@redhat.com, Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH] Simplify edksetup.sh
Date: Mon, 15 Jul 2019 09:01:14 -0600	[thread overview]
Message-ID: <720144d6-20d0-bf18-f00c-e0cddfafd0f5@bsdio.com> (raw)
In-Reply-To: <20190715145521.4nkakcli5rjjjaun@bivouac.eciton.net>

On 2019-07-15 08:55, Leif Lindholm wrote:
>
> For me, the question is more with being able to trivially discern
> which patch does what. I agree they're all individually trivial, but
> as a single patch there is enough going on at once that it makes it
> easier for bugs to slip through review. (And we've had issues with
> this in the past in edksetup.sh.)



Thanks, I understand now. I'll resubmit the changes as a series.


-- 

Rebecca Cran


  reply	other threads:[~2019-07-15 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 21:17 [PATCH] Simplify edksetup.sh Rebecca Cran
2019-07-12 16:05 ` [edk2-devel] " rebecca
2019-07-12 22:21 ` Laszlo Ersek
2019-07-15 14:40   ` rebecca
2019-07-15 14:55     ` Leif Lindholm
2019-07-15 15:01       ` rebecca [this message]
2019-07-15 17:48         ` Laszlo Ersek
2019-07-15 17:45     ` Laszlo Ersek
2019-07-15 22:37       ` rebecca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720144d6-20d0-bf18-f00c-e0cddfafd0f5@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox