From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>,
Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
Date: Tue, 28 Apr 2020 15:59:10 +0200 [thread overview]
Message-ID: <723204dc-1f1b-033e-512f-86788c17b593@redhat.com> (raw)
In-Reply-To: <5d7808b4-4b86-bc48-001b-ecd7eb746390@bsdio.com>
On 4/28/20 3:38 PM, Rebecca Cran wrote:
> On 4/28/20 6:44 AM, Laszlo Ersek wrote:
>
>>
>> Rebecca: thanks for the contribution. Personally I'd have preferred a
>> finer-grained approach here, but Phil removed the review burden on me.
>>
>> Regarding the git history, edk2 unfortunately alreay carries a bunch of
>> similarly large (even huge) coding style update patches, so I I can't
>> hold that perspective against the patch.
>
> Thanks. I did think I'd get some push-back against such a large patch
> and considered splitting it up but given it is such a simple, mechanical
> change I decided to submit it as is.
Patch reproduced using:
$ sed -i -e s/EFI_D_INFO/DEBUG_INFO/ $(git grep -l EFI_D_INFO OvmfPkg/)
Adding a comment "patch produced mechanically using ..." in the commit
message help review and probably give confidence to maintainers: 1 line
to review ;)
next prev parent reply other threads:[~2020-04-28 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 22:17 [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones Rebecca Cran
2020-04-27 8:56 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-04-28 12:44 ` Laszlo Ersek
2020-04-28 12:55 ` Philippe Mathieu-Daudé
2020-04-28 13:38 ` Rebecca Cran
2020-04-28 13:59 ` Philippe Mathieu-Daudé [this message]
2020-04-28 22:57 ` Laszlo Ersek
2020-04-29 0:38 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723204dc-1f1b-033e-512f-86788c17b593@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox