From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.42.1588082359510695429 for ; Tue, 28 Apr 2020 06:59:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HiJap3Da; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588082358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6wR5HegQC/oPjeed4tmrSAXFzIF8CMaa1w6AD7+kiU8=; b=HiJap3Dah41hvejZbMbVMb1KDZctOvmOrYip4SoQdx0Z+FiYDOsEh6x7IEvdzznlx+FoCQ U+5/0r/LuUt2Aj2YbWdICrBRsVdk0GWyhH0sVc0LmnRNkiKnD+WadjaZFfmPwKLCdPt5/2 p8Dpq2I86FBaXwIcSNPzOq2I/SBvDu0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-XfitlfIRM26PjNSnaXunYQ-1; Tue, 28 Apr 2020 09:59:17 -0400 X-MC-Unique: XfitlfIRM26PjNSnaXunYQ-1 Received: by mail-wm1-f69.google.com with SMTP id b203so875419wmd.6 for ; Tue, 28 Apr 2020 06:59:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6wR5HegQC/oPjeed4tmrSAXFzIF8CMaa1w6AD7+kiU8=; b=CZNpJgwPJLrqt7Ma/utZ5ynDm0V5keNvezk5/nNiOfOIviycP1Bta0ltkirI5XUGN0 QodaujWAxkeNpLKPrUJPCoeIigLbCmlJA/zwgit3dCa1UxeLT4LotGNwR2kokFljo+E0 8ZTKZLcZeBgJ6Ytb0Yp/03bNbpG8K+1abpKbLUJESln5jZjGsBLahpYNJDsYHjxOdtZc c2Ws2XuEl2m+0ZaQc/aBNhPTh1VwQXkdrQXQEhg7a9rbHmBbGHGfVFoz1LjQAiQLH5c4 Tz2zA3AqAAISDDrdrzEvXH/OI6rH2IcZ099Du5nBprkDkHdeVRtHLOopYawrCCF6OIAQ 0kLg== X-Gm-Message-State: AGi0Puad9mnhT9KMzxBzQw3WPob+TKa6TSXZvICr8RP8oP62kXQ0GAXz YO+hCwmHqGki3ORAaIxTe45HpRCHMpkOLxbxdaD11GO7+8vQNvesL/2BOTCshXEdO9Kzvji6CiM eIed4NEPe5DbQIg== X-Received: by 2002:a5d:420a:: with SMTP id n10mr31997400wrq.235.1588082355877; Tue, 28 Apr 2020 06:59:15 -0700 (PDT) X-Google-Smtp-Source: APiQypIrXQf/3yD6RfpOof8m4cJkt8aiQutZItaI/Gm83VDDgfCUIBQzEnbymG2QIuLZ2YZuToE1FA== X-Received: by 2002:a5d:420a:: with SMTP id n10mr31997193wrq.235.1588082352460; Tue, 28 Apr 2020 06:59:12 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id k184sm3514063wmf.9.2020.04.28.06.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 06:59:11 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones To: Rebecca Cran , Laszlo Ersek , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel References: <20200424221707.183492-1-rebecca@bsdio.com> <6969918a-0948-559e-7679-ba94e8f3bfd8@redhat.com> <5d7808b4-4b86-bc48-001b-ecd7eb746390@bsdio.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <723204dc-1f1b-033e-512f-86788c17b593@redhat.com> Date: Tue, 28 Apr 2020 15:59:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <5d7808b4-4b86-bc48-001b-ecd7eb746390@bsdio.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 4/28/20 3:38 PM, Rebecca Cran wrote: > On 4/28/20 6:44 AM, Laszlo Ersek wrote: > >> >> Rebecca: thanks for the contribution. Personally I'd have preferred a >> finer-grained approach here, but Phil removed the review burden on me. >> >> Regarding the git history, edk2 unfortunately alreay carries a bunch of >> similarly large (even huge) coding style update patches, so I I can't >> hold that perspective against the patch. > > Thanks. I did think I'd get some push-back against such a large patch > and considered splitting it up but given it is such a simple, mechanical > change I decided to submit it as is. Patch reproduced using: $ sed -i -e s/EFI_D_INFO/DEBUG_INFO/ $(git grep -l EFI_D_INFO OvmfPkg/) Adding a comment "patch produced mechanically using ..." in the commit message help review and probably give confidence to maintainers: 1 line to review ;)