From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F65E1A1DFA for ; Fri, 29 Jul 2016 10:12:52 -0700 (PDT) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Sat, 30 Jul 2016 01:12:49 +0800 From: Tim Lewis To: Leif Lindholm , Laszlo Ersek CC: "michael.d.kinney@intel.com" , Jordan Justen , "edk2-devel@ml01.01.org" , Andrew Fish Thread-Topic: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex Thread-Index: AQHR2FtLOABN7ESjZk2960dXU4o2AqAMioqAgCKvmoCAAIa/0A== Date: Fri, 29 Jul 2016 17:12:49 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53F3D487A@msmail.insydesw.com.tw> References: <1467901459-18840-1-git-send-email-leif.lindholm@linaro.org> <20160729164433.GO31760@bivouac.eciton.net> In-Reply-To: <20160729164433.GO31760@bivouac.eciton.net> Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.100.109] MIME-Version: 1.0 Subject: Re: [PATCH] add top-level .gitattributes file, dealing with .depex X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 17:12:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It appears that this file is not actually used. It is only referenced in th= e [Rule.Common.UEFI_DRIVER.NATIVE_BINARY] rule in PlatformPkg.fdf. A little= further research shows that an alternate method was used for the actual GO= P binary (see below). A grep of the entire tree shows that no one uses this= rule NATIVE_BINARY. So it looks like it can just be cut out. BTW, the downside of the method used for the binary version of the GOP driv= er, is that those drivers cannot use PCDs, since the PCD database is create= d based on references in the .inf. GOP works because it is pure UEFI and (t= herefore) doesn't use PCDs. Tim FILE DRIVER =3D FF0C8745-3270-4439-B74F-3E45F8C77064 { SECTION DXE_DEPEX_EXP =3D {gPlatformGOPPolicyGuid} SECTION PE32 =3D Vlv2MiscBinariesPkg/GOP/7.2.1011/RELEASE_VS2008x86/$(DXE= _ARCHITECTURE)/IntelGopDriver.efi SECTION UI =3D "IntelGopDriver" } -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif= Lindholm Sent: Friday, July 29, 2016 9:45 AM To: Laszlo Ersek Cc: michael.d.kinney@intel.com; Jordan Justen ; = edk2-devel@ml01.01.org; Andrew Fish Subject: Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with= .depex On Thu, Jul 07, 2016 at 05:03:13PM +0200, Laszlo Ersek wrote: > On 07/07/16 16:24, Leif Lindholm wrote: > > Git tends to see .depex files as text, causing hideous patches being=20 > > generated (and breaking PatchCheck.py). > >=20 > > Add a .gitattributes file instructing git to treat them as binary. > >=20 > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Leif Lindholm > > --- > > .gitattributes | 1 + > > 1 file changed, 1 insertion(+) > > create mode 100644 .gitattributes > >=20 > > diff --git a/.gitattributes b/.gitattributes new file mode 100644=20 > > index 0000000..2d8a45b > > --- /dev/null > > +++ b/.gitattributes > > @@ -0,0 +1 @@ > > +*.depex binary > >=20 >=20 > What generates .depex files? I've never seen any. >=20 > Also, unless you add .depex files with "git add" to the set of tracked=20 > files, no patches / diffs should cover them. What am I missing? :) >=20 > ... Hm, after >=20 > $ find . -iname "*.depex" >=20 > I see .depex files in Build/ (which should be ignored altogether), and >=20 > ./Vlv2TbltDevicePkg/IntelGopDepex/IntelGopDriver.depex >=20 > Why does that file exist in the tree? Let me see... git log says nothing = relevant (the file dates back to commit 3cbfba02fef9, "Upload BSD-licensed = Vlv2TbltDevicePkg and Vlv2DeviceRefCodePkg to"). >=20 > Grepping the tree for the filename itself leads to: >=20 > Vlv2TbltDevicePkg/PlatformPkg.fdf: DXE_DEPEX DXE_DEPEX Optional $= (WORKSPACE)/$(PLATFORM_PACKAGE)/IntelGopDepex/IntelGopDriver.depex > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf: DXE_DEPEX DXE_DEPEX Optional = $(WORKSPACE)/$(PLATFORM_PACKAGE)/IntelGopDepex/IntelGopDriver.depex >=20 > Do these rules exist to override the DEPEX sections of binary-only module= s? If so: that's horrible. >=20 > Anyway, given that edk2 contains at least one .depex file, and your patch= is correct according to : >=20 > Reviewed-by: Laszlo Ersek Thanks! I had hoped for comments from someone else on cc, since we don't have any M= aintainers.txt entry for the top level directory :) But if I don't hear anything before Monday, I'll push it then. Regards, Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel