From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0793A1A1DF5 for ; Fri, 5 Aug 2016 12:16:44 -0700 (PDT) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Sat, 6 Aug 2016 03:16:42 +0800 From: Tim Lewis To: "Carsey, Jaben" , Meenakshi Aggarwal , "edk2-devel@lists.01.org" Thread-Topic: Shell version 2.2 Thread-Index: AdHu+W3lndTU8FzJTNWqMdU/Mik5KQARG1wwAAJ26aAAAUJQAAAAG/Sw Date: Fri, 5 Aug 2016 19:16:41 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53F3DA697@msmail.insydesw.com.tw> References: <7236196A5DF6C040855A6D96F556A53F3DA5B3@msmail.insydesw.com.tw> In-Reply-To: Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.9.107] MIME-Version: 1.0 Subject: Re: Shell version 2.2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 19:16:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, but they are the same numbers. So I think this is probably a=20 The specification says (in the Shell protocol section's Related Defintiions= ): #define EFI_SHELL_MAJOR_VERSION 2 #define EFI_SHELL_MINOR_VERSION 2 And, from ver.c: ShellPrintHiiEx ( 0, gST->ConOut->Mode->CursorRow, NULL, STRING_TOKEN (STR_VER_OUTPUT_SIMPLE), gShellLevel3HiiHandle, gEfiShellProtocol->MajorVersion, gEfiShellProtocol->MinorVersion ); And the shell protocol instance comes from ShellProtocol.c (see below): EFI_SHELL_PROTOCOL mShellProtocol =3D { EfiShellExecute, EfiShellGetEnv, EfiShellSetEnv, EfiShellGetAlias, EfiShellSetAlias, EfiShellGetHelpText, EfiShellGetDevicePathFromMap, EfiShellGetMapFromDevicePath, EfiShellGetDevicePathFromFilePath, EfiShellGetFilePathFromDevicePath, EfiShellSetMap, EfiShellGetCurDir, EfiShellSetCurDir, EfiShellOpenFileList, EfiShellFreeFileList, EfiShellRemoveDupInFileList, EfiShellBatchIsActive, EfiShellIsRootShell, EfiShellEnablePageBreak, EfiShellDisablePageBreak, EfiShellGetPageBreak, EfiShellGetDeviceName, (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo, //* (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo, //* EfiShellOpenFileByName, EfiShellClose, EfiShellCreateFile, (EFI_SHELL_READ_FILE)FileHandleRead, //* (EFI_SHELL_WRITE_FILE)FileHandleWrite, //* (EFI_SHELL_DELETE_FILE)FileHandleDelete, //* EfiShellDeleteFileByName, (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //* (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //* (EFI_SHELL_FLUSH_FILE)FileHandleFlush, //* EfiShellFindFiles, EfiShellFindFilesInDir, (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize, //* EfiShellOpenRoot, EfiShellOpenRootByHandle, NULL, SHELL_MAJOR_VERSION, SHELL_MINOR_VERSION, // New for UEFI Shell 2.1 EfiShellRegisterGuidName, EfiShellGetGuidName, EfiShellGetGuidFromName, EfiShellGetEnvEx }; -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Cars= ey, Jaben Sent: Friday, August 05, 2016 12:10 PM To: Tim Lewis ; Meenakshi Aggarwal ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: Re: [edk2] Shell version 2.2 Tim, Yes, ver command would output that the version of the shell is different. The #define below is specifically the version of the Protocol, not the vers= ion of the spec. It could have been a miss on the part of the committee, but that was hoe I = interpreted the non-change to the protocol version. -Jaben > -----Original Message----- > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Friday, August 5, 2016 11:36 AM > To: Carsey, Jaben ; Meenakshi Aggarwal=20 > ; edk2-devel@lists.01.org devel@ml01.01.org> > Subject: RE: Shell version 2.2 > Importance: High >=20 > Jaben -- >=20 > Are there no shell commands where the standard command-line parameters=20 > have changed? >=20 > Tim >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Carsey, Jaben > Sent: Friday, August 05, 2016 10:26 AM > To: Meenakshi Aggarwal ; edk2-=20 > devel@lists.01.org > Cc: Carsey, Jaben > Subject: Re: [edk2] Shell version 2.2 >=20 > I think that that version (2.1) is correct for the version of the=20 > protocol. The protocol API was not changed for the UEFI Shell 2.2. >=20 > That is the current version and should support the 2.2 spec. >=20 > -Jaben >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 > > Of Meenakshi Aggarwal > > Sent: Friday, August 5, 2016 2:20 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] Shell version 2.2 > > Importance: High > > > > Hi, > > > > > > I can see UEFI shell specification 2.2 > > (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd > > f) is available, But on edk2 master branch current version of Shell=20 > > is still showing > 2.1. > > > > File:ShellPkg/Include/Protocol/EfiShell.h > > > > enum ShellVersion { > > SHELL_MAJOR_VERSION =3D 2, > > SHELL_MINOR_VERSION =3D 1 > > }; > > > > > > > > Please tell if I am looking at correct file, actually I want to=20 > > update my shell to 2.2, but it looks like edk2 master branch doesn't=20 > > support shell > specification 2.2. > > > > Is my understanding correct? > > > > > > > > Thanks & Regards, > > Meenakshi > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel