From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55DF71A1E9E for ; Fri, 14 Oct 2016 09:21:14 -0700 (PDT) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Sat, 15 Oct 2016 00:21:11 +0800 From: Tim Lewis To: "Yao, Jiewen" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Thread-Index: AQHSJf+W7FepF7yD9UWsvghBDx/1jqCnZhuAgAABYYCAALlGIA== Date: Fri, 14 Oct 2016 16:21:11 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53F3F6BEF@msmail.insydesw.com.tw> References: <20161014094431.473584-1-ruiyu.ni@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B192B@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B1971@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386B1971@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.100.108] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Move Shell protocol definitions to MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 16:21:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I prefer the renamed .h file, even though I have substantial investment in = the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X tra= nslate to header file Y" It should be a consistent rule. How many times hav= e I needed to grep the header file name just because I got a build error be= cause the rule wasn't predictable. 1) remove the EFI_ prefix and the _PROTOCOL suffix (EFI_BLOCK_IO_PROTOCOL = -> BLOCK_IO 2) Convert to upper-and-lower case, BLOCK_IO -> Block_Io=20 3) Remove the _ (Block_Io -> BlockIo) 4) add a .h BlockIo -> BlockIo.h Most protocol and PPI header files already follow this rule. The current he= ader files for shell are among the few exceptions, because they don't follo= w this. Tim -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, October 14, 2016 6:14 AM To: Yao, Jiewen ; Ni, Ruiyu ; edk= 2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Or if you really think we should give a better name. My recommendation is: 1) We add content in MdePkg. 2) We can keep the old protocol file in ShellPkg, but let .h in shellP= kg include the .h in MdePkg. Then we can avoid duplicated code and make it a compatible solution to avoi= d other module update. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, October 14, 2016 9:09 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Hi I think the requests is just to *move*. There is no request to *rename*. Can we just move to avoid other update? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Ruiyu Ni > Sent: Friday, October 14, 2016 5:44 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg > > The patches moves Shell spec defined protocol definitions to MdePkg=20 > and updates all references. > Content of ShellBase.h is moved to Protocol/Shell.h and ShellBase.h is=20 > removed. > > Ruiyu Ni (5): > ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h > MdePkg: Include Shell/ShellDynamicCommand/ShellParameters > definitions > ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg > EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg > ShellPkg: Remove Shell/ShellDynamicCommand/ShellParameter > definitions > > ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 +- > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 +- > .../EfiShell.h =3D> MdePkg/Include/Protocol/Shell.h | 134 > +++++++++++++++++- > .../Include/Protocol/ShellDynamicCommand.h | 7 +- > .../Include/Protocol/ShellParameters.h | 4 +- > MdePkg/MdePkg.dec | 15 ++ > ShellPkg/Application/Shell/Shell.h | 5 +- > ShellPkg/Include/Library/ShellCommandLib.h | 5 +- > ShellPkg/Include/Library/ShellLib.h | 14 +- > ShellPkg/Include/ShellBase.h | 157 > --------------------- > ShellPkg/Library/UefiDpLib/Dp.h | 3 +- > ShellPkg/Library/UefiDpLib/UefiDpLib.h | 7 +- > .../UefiHandleParsingLib/UefiHandleParsingLib.h | 8 +- > .../UefiShellBcfgCommandLib.c | 5 +- > .../UefiShellCEntryLib/UefiShellCEntryLib.c | 6 +- > .../UefiShellCommandLib/UefiShellCommandLib.h | 7 +- > .../Library/UefiShellDebug1CommandsLib/Compress.c | 7 +- > .../UefiShellDebug1CommandsLib.h | 7 +- > .../UefiShellDriver1CommandsLib.h | 7 +- > .../UefiShellLevel1CommandsLib.h | 7 +- > .../UefiShellLevel2CommandsLib.h | 7 +- > ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c | 2 +- > .../UefiShellLevel3CommandsLib.h | 7 +- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 - > ShellPkg/Library/UefiShellLib/UefiShellLib.h | 6 +- > .../UefiShellNetwork1CommandsLib.h | 3 +- > .../UefiShellTftpCommandLib.h | 3 +- > ShellPkg/ShellPkg.dec | 3 - > ShellPkg/ShellPkg.dsc | 2 + > 29 files changed, 213 insertions(+), 234 deletions(-) rename=20 > ShellPkg/Include/Protocol/EfiShell.h =3D>=20 > MdePkg/Include/Protocol/Shell.h (92%) rename=20 > ShellPkg/Include/Protocol/EfiShellDynamicCommand.h =3D>=20 > MdePkg/Include/Protocol/ShellDynamicCommand.h (92%) rename=20 > ShellPkg/Include/Protocol/EfiShellParameters.h =3D>=20 > MdePkg/Include/Protocol/ShellParameters.h (92%) delete mode 100644=20 > ShellPkg/Include/ShellBase.h > > -- > 2.9.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel