From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tim.lewis@insyde.com>
Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 44F7B1A1E05
 for <edk2-devel@lists.01.org>; Tue, 18 Oct 2016 03:18:29 -0700 (PDT)
Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by
 msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id
 14.01.0438.000; Tue, 18 Oct 2016 18:18:27 +0800
From: Tim Lewis <tim.lewis@insyde.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Thread-Topic: [shell] Problems in EfiShellGetGuidFromName
Thread-Index: AdIlfdpU1v/3CG20S5OHaNM46qeDngDqw2ag
Date: Tue, 18 Oct 2016 10:18:26 +0000
Message-ID: <7236196A5DF6C040855A6D96F556A53F3F84EF@msmail.insydesw.com.tw>
References: <7236196A5DF6C040855A6D96F556A53F3F660F@msmail.insydesw.com.tw>
In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3F660F@msmail.insydesw.com.tw>
Accept-Language: en-US, zh-TW
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [1.165.0.65]
MIME-Version: 1.0
Subject: FW: [shell] Problems in EfiShellGetGuidFromName
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Oct 2016 10:18:29 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2=
 implementation?

Thanks,

Tim

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tim =
Lewis
Sent: Thursday, October 13, 2016 11:16 AM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: [edk2] [shell] Problems in EfiShellGetGuidFromName

In EfiShellGetGuidFromName (ShellProtocol.c), we see:

EfiShellGetGuidFromName(
  IN  CONST CHAR16   *GuidName,
  OUT       EFI_GUID *Guid
  )
{
  EFI_GUID    *NewGuid;
  EFI_STATUS  Status;

  if (Guid =3D=3D NULL || GuidName =3D=3D NULL) {
    return (EFI_INVALID_PARAMETER);
  }

  Status =3D GetGuidFromStringName(GuidName, NULL, &NewGuid);
  if (!EFI_ERROR(Status)) {
    CopyGuid(NewGuid, Guid);
  }
  return (Status);

However, this doesn't work. Notice that CopyGuid places the output paramete=
r as the 2nd parameter. But according to BaseMemoryLib:

GUID *
EFIAPI
CopyGuid (
  OUT GUID       *DestinationGuid,
  IN CONST GUID  *SourceGuid
  );

The destination should be the 1st parameter (not the second).



_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel