From: Tim Lewis <tim.lewis@insyde.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [shell] AliasLower never used in InternalSetAlias
Date: Thu, 27 Oct 2016 21:11:02 +0000 [thread overview]
Message-ID: <7236196A5DF6C040855A6D96F556A53F3FD11D@msmail.insydesw.com.tw> (raw)
In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never actually used. Am I missing something?
// Convert to lowercase to make aliases case-insensitive
if (Alias != NULL) {
AliasLower = AllocateCopyPool (StrSize (Alias), Alias);
if (AliasLower == NULL) {
return EFI_OUT_OF_RESOURCES;
}
ToLower (AliasLower);
} else {
AliasLower = NULL;
}
//
// We must be trying to remove one if Alias is NULL
//
if (Alias == NULL) {
//
// remove an alias (but passed in COMMAND parameter)
//
Status = (gRT->SetVariable((CHAR16*)Command, &gShellAliasGuid, 0, 0, NULL));
} else {
//
// Add and replace are the same
//
// We dont check the error return on purpose since the variable may not exist.
gRT->SetVariable((CHAR16*)Command, &gShellAliasGuid, 0, 0, NULL);
Status = (gRT->SetVariable((CHAR16*)Alias, &gShellAliasGuid, EFI_VARIABLE_BOOTSERVICE_ACCESS|(Volatile?0:EFI_VARIABLE_NON_VOLATILE), StrSize(Command), (VOID*)Command));
}
if (Alias != NULL) {
FreePool (AliasLower);
}
next reply other threads:[~2016-10-27 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 21:11 Tim Lewis [this message]
2016-10-27 21:29 ` [shell] AliasLower never used in InternalSetAlias Tim Lewis
2016-10-28 15:20 ` Carsey, Jaben
2016-10-28 16:48 ` Tim Lewis
2016-10-28 16:58 ` Carsey, Jaben
2016-10-28 17:03 ` Tim Lewis
2016-10-28 17:04 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7236196A5DF6C040855A6D96F556A53F3FD11D@msmail.insydesw.com.tw \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox