public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Tim Lewis <tim.lewis@insyde.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [shell] Pipe causes pool failure in Shell.c
Date: Fri, 2 Dec 2016 21:48:31 +0000	[thread overview]
Message-ID: <7236196A5DF6C040855A6D96F556A53F4110EA@msmail.insydesw.com.tw> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515C54B01D12@FMSMSX103.amr.corp.intel.com>

Jaben --

I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it.

Tim

-----Original Message-----
From: Carsey, Jaben [mailto:jaben.carsey@intel.com] 
Sent: Friday, December 02, 2016 8:39 AM
To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
Subject: RE: [shell] Pipe causes pool failure in Shell.c

Does that leak memory?  It looks like that memory was allocated at 1720, then moved from Out to In at 1729-1735.

Did the pointer possibly get mangled at 1724 or somewhere in between?

Ray,  Have you seen this?

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Tim Lewis
> Sent: Thursday, December 01, 2016 11:45 PM
> To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel@lists.01.org
> Subject: [edk2] [shell] Pipe causes pool failure in Shell.c
> Importance: High
> 
> After looking further, it appears that the FreePool() call on line 
> 1756 is unnecessary, and just causes a breakpoint.
> 
> Removing it allows the functionality to work correctly.
> 
> //    FreePool (Split->SplitStdIn);
> 
> 
> Tim
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Tim Lewis
> Sent: Thursday, December 01, 2016 5:48 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Pipe causes pool failure in Shell.c
> 
> Using the latest Shell build, try:
> 
> ls -sfo | parse FileInfo 2
> 
> This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.
> 
> I'm still debugging, but I wondered if anyone else has seen this?
> 
> Also:
> 
> ls -sfo > tmp
> parse FileInfo 2 < tmp
> 
> prints nothing, but
> 
> parse tmp FileInfo 2
> 
> works fine.
> 
> Tim
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2016-12-02 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02  7:44 [shell] Pipe causes pool failure in Shell.c Tim Lewis
2016-12-02 16:39 ` Carsey, Jaben
2016-12-02 21:48   ` Tim Lewis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7236196A5DF6C040855A6D96F556A53F4110EA@msmail.insydesw.com.tw \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox