From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B419981F5F for ; Fri, 2 Dec 2016 13:48:35 -0800 (PST) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Sat, 3 Dec 2016 05:48:33 +0800 From: Tim Lewis To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [shell] Pipe causes pool failure in Shell.c Thread-Index: AdJMb+c9NhfY6jUuS3GDj+qFTwT7ewASVvHAAAsd9nA= Date: Fri, 2 Dec 2016 21:48:31 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53F4110EA@msmail.insydesw.com.tw> References: <7236196A5DF6C040855A6D96F556A53F410D2D@msmail.insydesw.com.tw> In-Reply-To: Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.146.58.88] MIME-Version: 1.0 Subject: Re: [shell] Pipe causes pool failure in Shell.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 21:48:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jaben -- I'm not sure. In the debugger, it clearly showed the memory as having alrea= dy been freed at the pointer. But I didn't track down who had done it. Tim -----Original Message----- From: Carsey, Jaben [mailto:jaben.carsey@intel.com]=20 Sent: Friday, December 02, 2016 8:39 AM To: Tim Lewis ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben Subject: RE: [shell] Pipe causes pool failure in Shell.c Does that leak memory? It looks like that memory was allocated at 1720, th= en moved from Out to In at 1729-1735. Did the pointer possibly get mangled at 1724 or somewhere in between? Ray, Have you seen this? -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Tim Lewis > Sent: Thursday, December 01, 2016 11:45 PM > To: Tim Lewis ; edk2-devel@lists.01.org > Subject: [edk2] [shell] Pipe causes pool failure in Shell.c > Importance: High >=20 > After looking further, it appears that the FreePool() call on line=20 > 1756 is unnecessary, and just causes a breakpoint. >=20 > Removing it allows the functionality to work correctly. >=20 > // FreePool (Split->SplitStdIn); >=20 >=20 > Tim > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Tim Lewis > Sent: Thursday, December 01, 2016 5:48 PM > To: edk2-devel@lists.01.org > Subject: [edk2] Pipe causes pool failure in Shell.c >=20 > Using the latest Shell build, try: >=20 > ls -sfo | parse FileInfo 2 >=20 > This ends up with a breakpoint when FreePool is called on Shell.c, line 1= 756. >=20 > I'm still debugging, but I wondered if anyone else has seen this? >=20 > Also: >=20 > ls -sfo > tmp > parse FileInfo 2 < tmp >=20 > prints nothing, but >=20 > parse tmp FileInfo 2 >=20 > works fine. >=20 > Tim > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel