* [shell] Pipe causes pool failure in Shell.c
@ 2016-12-02 7:44 Tim Lewis
2016-12-02 16:39 ` Carsey, Jaben
0 siblings, 1 reply; 3+ messages in thread
From: Tim Lewis @ 2016-12-02 7:44 UTC (permalink / raw)
To: Tim Lewis, edk2-devel@lists.01.org
After looking further, it appears that the FreePool() call on line 1756 is unnecessary, and just causes a breakpoint.
Removing it allows the functionality to work correctly.
// FreePool (Split->SplitStdIn);
Tim
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tim Lewis
Sent: Thursday, December 01, 2016 5:48 PM
To: edk2-devel@lists.01.org
Subject: [edk2] Pipe causes pool failure in Shell.c
Using the latest Shell build, try:
ls -sfo | parse FileInfo 2
This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.
I'm still debugging, but I wondered if anyone else has seen this?
Also:
ls -sfo > tmp
parse FileInfo 2 < tmp
prints nothing, but
parse tmp FileInfo 2
works fine.
Tim
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [shell] Pipe causes pool failure in Shell.c
2016-12-02 7:44 [shell] Pipe causes pool failure in Shell.c Tim Lewis
@ 2016-12-02 16:39 ` Carsey, Jaben
2016-12-02 21:48 ` Tim Lewis
0 siblings, 1 reply; 3+ messages in thread
From: Carsey, Jaben @ 2016-12-02 16:39 UTC (permalink / raw)
To: Tim Lewis, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Carsey, Jaben
Does that leak memory? It looks like that memory was allocated at 1720, then moved from Out to In at 1729-1735.
Did the pointer possibly get mangled at 1724 or somewhere in between?
Ray, Have you seen this?
-Jaben
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Thursday, December 01, 2016 11:45 PM
> To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel@lists.01.org
> Subject: [edk2] [shell] Pipe causes pool failure in Shell.c
> Importance: High
>
> After looking further, it appears that the FreePool() call on line 1756 is
> unnecessary, and just causes a breakpoint.
>
> Removing it allows the functionality to work correctly.
>
> // FreePool (Split->SplitStdIn);
>
>
> Tim
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Thursday, December 01, 2016 5:48 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Pipe causes pool failure in Shell.c
>
> Using the latest Shell build, try:
>
> ls -sfo | parse FileInfo 2
>
> This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.
>
> I'm still debugging, but I wondered if anyone else has seen this?
>
> Also:
>
> ls -sfo > tmp
> parse FileInfo 2 < tmp
>
> prints nothing, but
>
> parse tmp FileInfo 2
>
> works fine.
>
> Tim
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [shell] Pipe causes pool failure in Shell.c
2016-12-02 16:39 ` Carsey, Jaben
@ 2016-12-02 21:48 ` Tim Lewis
0 siblings, 0 replies; 3+ messages in thread
From: Tim Lewis @ 2016-12-02 21:48 UTC (permalink / raw)
To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Jaben --
I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it.
Tim
-----Original Message-----
From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Friday, December 02, 2016 8:39 AM
To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
Subject: RE: [shell] Pipe causes pool failure in Shell.c
Does that leak memory? It looks like that memory was allocated at 1720, then moved from Out to In at 1729-1735.
Did the pointer possibly get mangled at 1724 or somewhere in between?
Ray, Have you seen this?
-Jaben
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Thursday, December 01, 2016 11:45 PM
> To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel@lists.01.org
> Subject: [edk2] [shell] Pipe causes pool failure in Shell.c
> Importance: High
>
> After looking further, it appears that the FreePool() call on line
> 1756 is unnecessary, and just causes a breakpoint.
>
> Removing it allows the functionality to work correctly.
>
> // FreePool (Split->SplitStdIn);
>
>
> Tim
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Thursday, December 01, 2016 5:48 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Pipe causes pool failure in Shell.c
>
> Using the latest Shell build, try:
>
> ls -sfo | parse FileInfo 2
>
> This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.
>
> I'm still debugging, but I wondered if anyone else has seen this?
>
> Also:
>
> ls -sfo > tmp
> parse FileInfo 2 < tmp
>
> prints nothing, but
>
> parse tmp FileInfo 2
>
> works fine.
>
> Tim
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-02 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-02 7:44 [shell] Pipe causes pool failure in Shell.c Tim Lewis
2016-12-02 16:39 ` Carsey, Jaben
2016-12-02 21:48 ` Tim Lewis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox