From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 751EE21A16E21 for ; Tue, 16 May 2017 11:04:27 -0700 (PDT) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Wed, 17 May 2017 02:04:25 +0800 From: Tim Lewis To: Star Zeng , "edk2-devel@lists.01.org" CC: Star Zeng , Michael Kinney , Liming Gao , Yonghong Zhu Thread-Topic: [RFC] PCD: Database size optimization for multi-SKU Thread-Index: AQHSzlFcNB2K4sn7Nk+UJxddWx9oQ6H3QRDY Date: Tue, 16 May 2017 18:04:23 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53F57EC06@msmail.insydesw.com.tw> References: <1494945185-34504-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1494945185-34504-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [RFC] PCD: Database size optimization for multi-SKU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 18:04:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star- One more requirement that I propose is the the format update be detectable = easily by inspection of the binary image. We have tools that dump and manip= ulate the PCD database and the revision or version number allows us to supp= ort multiple core versions. I think this is already your intent and I want = to make it an explicit requirement. Other than that, I think this is a much needed change for multi-sku firmwar= e images. Thanks, Tim Sent from my Windows 10 phone From: Star Zeng Sent: Tuesday, May 16, 2017 7:33 AM To: edk2-devel@lists.01.org Cc: Star Zeng; Michael Kinney; Liming Gao; Tim Lewis; Yonghong Zhu Subject: [RFC] PCD: Database size optimization for multi-SKU - Requirement Reduce PCD database size for multi-SKU case to save image size at build tim= e and memory resource at boot time. - Current limitation When multiple SKUs are enabled, the full set of PCD values for all SKUs wil= l be generated into PCD database, and HOB will be created for the PCD database, the HOB will consume much mem= ory resource when many SKUs are specified, but the HOB length and pre-memory phase memory resource are limited. - Proposal BaseTools can generate the optimized PCD database to save the image size at= build time, the optimized PCD database layout will be like below, the PCD database will= be composed of the full default SKU data(PCD_DATABASE_INIT) and the non-default SKU delta data(PCD_= DATABASE_SKU_DELTA). PCD driver will build HOB to store the full default SKU data, and patch HOB= data based on non-default SKU delta data for the SKU set by SetSku(), it can save memory = resource at boot time. // // PCD database layout: // +---------------------------------+ // | PCD_DATABASE_INIT (DEFAULT SKU) | // +---------------------------------+ // | PCD_DATABASE_SKU_DELTA (SKU A) | // +---------------------------------+ // | PCD_DATABASE_SKU_DELTA (SKU B) | // +---------------------------------+ // | ...... | // +---------------------------------+ // The patch below shows the detailed PCD database format change. BaseTools, PCD database and driver updates are needed for this proposal. BaseTools can even be intelligent to generate smallest SKU delta based on t= he PCD values for different SKUs and the relationship between SKUs. For single SKU (default) case, this proposal is expected to have no impact. Note: For multi-SKU case, PCD database format will be changed, so PCD drive= r will have to be updated together with BaseTools. Cc: Michael Kinney Cc: Liming Gao Cc: Tim Lewis Cc: Yonghong Zhu --- .../Include/Guid/PcdDataBaseSignatureGuid.h | 32 +++++++++++++++++-= ---- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModu= lePkg/Include/Guid/PcdDataBaseSignatureGuid.h index d2e848800b75..0069823458cd 100644 --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h @@ -62,11 +62,6 @@ typedef struct { } DYNAMICEX_MAPPING; typedef struct { - UINT32 SkuDataStartOffset; // Offset(with DATUM TYPE info) from the P= CD_DB. - UINT32 SkuIdTableOffset; // Offset from the PCD_DB. -} SKU_HEAD; - -typedef struct { UINT32 StringIndex; // Offset in String Table in units of UINT= 8. UINT32 DefaultValueOffset; // Offset of the Default Value. UINT16 GuidTableIndex; // Offset in Guid Table in units of GUID. @@ -115,7 +110,6 @@ typedef struct { // Padding is needed to keep necessary alignment // //SKU_ID SkuIdTable[]; // SkuIds sy= stem supports. - //SKU_ID SkuIndexTable[]; // SkuIds fo= r each PCD with SKU enable. //UINT64 ValueUint64[]; //UINT32 ValueUint32[]; //VPD_HEAD VpdHead[]; // VPD Offse= t @@ -125,7 +119,6 @@ typedef struct { //STRING_HEAD StringHead[]; // String PC= D //PCD_NAME_INDEX PcdNameTable[]; // PCD name = index info. It can be accessed by the PcdNameTableOffset. //VARIABLE_HEAD VariableHead[]; // HII PCD - //SKU_HEAD SkuHead[]; // Store SKU= info for each PCD with SKU enable. //UINT8 StringTable[]; // String fo= r String PCD value and HII PCD Variable Name. It can be accessed by StringT= ableOffset. //SIZE_INFO SizeTable[]; // MaxSize a= nd CurSize for String PCD. It can be accessed by SizeTableOffset. //UINT16 ValueUint16[]; @@ -134,6 +127,31 @@ typedef struct { } PCD_DATABASE_INIT; +typedef struct { + UINT32 Offset:24; + UINT32 Data:8; +} PCD_DATABASE_SKU_DELTA_DATA; + +typedef struct { + SKU_ID SkuId; + SKU_ID SkuIdCompared; + UINT32 Length; + //PCD_DATABASE_SKU_DELTA_DATA DeltaData[] +} PCD_DATABASE_SKU_DELTA; + +// +// PCD database layout: +// +---------------------------------+ +// | PCD_DATABASE_INIT (DEFAULT SKU) | +// +---------------------------------+ +// | PCD_DATABASE_SKU_DELTA (SKU A) | +// +---------------------------------+ +// | PCD_DATABASE_SKU_DELTA (SKU B) | +// +---------------------------------+ +// | ...... | +// +---------------------------------+ +// + // // PEI and DXE Pcd driver use the same PCD database // -- 2.7.0.windows.1