From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=211.75.113.220; helo=msmail.insydesw.com.tw; envelope-from=tim.lewis@insyde.com; receiver=edk2-devel@lists.01.org Received: from msmail.insydesw.com.tw (ms.insydesw.com [211.75.113.220]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC25C202E6152 for ; Mon, 16 Oct 2017 14:11:22 -0700 (PDT) Received: from msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05]) by msmail.insydesw.com.tw ([fe80::74f7:f173:f4aa:9a05%11]) with mapi id 14.01.0438.000; Tue, 17 Oct 2017 05:14:55 +0800 From: Tim Lewis To: "Jarlstrom, Laurie" , "Carsey, Jaben" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Thread-Index: AQHTRpxdBUqGjoBuMEy9hMGPshq3s6LmW5iAgACesJA= Date: Mon, 16 Oct 2017 21:14:55 +0000 Message-ID: <7236196A5DF6C040855A6D96F556A53FD3D290@msmail.insydesw.com.tw> References: <20171016073048.236980-1-ruiyu.ni@intel.com> <10380531DF222B45964BE3E93EFE5F0488F7E837@fmsmsx104.amr.corp.intel.com> In-Reply-To: <10380531DF222B45964BE3E93EFE5F0488F7E837@fmsmsx104.amr.corp.intel.com> Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [66.81.40.130] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 21:11:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable And we always turn off the multiple colors. Tim -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jarl= strom, Laurie Sent: Monday, October 16, 2017 12:47 PM To: Carsey, Jaben ; Ni, Ruiyu ;= edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/g= reen color The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE= to EFI_CYAN to get a brighter blue. thanks, Laurie =A0 laurie.jarlstrom@intel.com Intel SSG/STO/EBP (503) 712-9395 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Cars= ey, Jaben Sent: Monday, October 16, 2017 9:32 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/g= reen color Reviewed-by: Jaben Carsey We could also use some PCDs if different people really want different color= s in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green=20 > color > Importance: High >=20 > Some developers/QAs complain the color of directory or executable=20 > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLU= E, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel