From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 17 Apr 2019 03:52:58 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id E0D6130B4A5E;
	Wed, 17 Apr 2019 10:52:57 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-177.rdu2.redhat.com [10.10.120.177])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 689101001E9F;
	Wed, 17 Apr 2019 10:52:55 +0000 (UTC)
Subject: Re: [patch] ShellBinPkg: Remove ShellBinPkg
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Dandan Bi <dandan.bi@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
 Jaben Carsey <jaben.carsey@intel.com>, Ray Ni <ray.ni@intel.com>,
 Leif Lindholm <leif.lindholm@linaro.org>, Liming Gao <liming.gao@intel.com>
References: <20190417064011.7000-1-dandan.bi@intel.com>
 <CAKv+Gu8iKBbZY3ptxjDaC=wu5UtiGakL8+VNXDri48dRh=MSeA@mail.gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <72474caf-c936-1ff7-a92c-b0f279d5418e@redhat.com>
Date: Wed, 17 Apr 2019 12:52:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8iKBbZY3ptxjDaC=wu5UtiGakL8+VNXDri48dRh=MSeA@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 17 Apr 2019 10:52:57 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/17/19 09:16, Ard Biesheuvel wrote:
> On Tue, 16 Apr 2019 at 23:40, Dandan Bi <dandan.bi@intel.com> wrote:
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
>>
>> Remove ShellBinPkg from edk2.
>> If developers work on current edk2 master and still want to use Shell
>> binary after this removal, they can get it from source code in the Assets
>> part of edk2-stable201903 tag release page.
>> And from next release (edk2-stable201905 tag), we will publish all Shell
>> binaries to the according Assets part directly.
>> edk2 release link: https://github.com/tianocore/edk2/releases
>>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> BTW you can use the --no-binary option to git to omit the binary diffs
> in the patch. Especially when deleting binaries, that saves a lot of
> hassle dealing with a multimegabyte patch email.

+1

For the patch, I have a request towards Dandan: regarding the line

+Maintainers for stable Shell binaries generation when need to publish Shell binaries with edk2 release:

please:

(1) wrap it with an 80-char margin,
(2) please insert a blank line just above it.

With those:

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo