From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.3824.1595274919670387201 for ; Mon, 20 Jul 2020 12:55:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pp466vN5; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595274918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u9SvcdjZlCnOnWH2lYqwpp72XcXKJdcmRJBqP5sgPwM=; b=Pp466vN5C1n0MKPRNKfERAI80jXpdhaNT1XSw/WbQmPycTDKYRBFaS7qKT3q3lNQdy1/d6 A3NXrZEEaemzlK5QGbnTFGDS4ntLZ5rPqcmQERT3/8m+Dfi1AFPa5XyEO2EqBkswWdjcdJ slv7BwjaUEUcNX1QjrHWGBnQC5aCFks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-kxKk9lvDP9-g-kto2Tkn9g-1; Mon, 20 Jul 2020 15:55:14 -0400 X-MC-Unique: kxKk9lvDP9-g-kto2Tkn9g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D66A5107ACCA; Mon, 20 Jul 2020 19:55:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-27.ams2.redhat.com [10.36.115.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C6EF512FE; Mon, 20 Jul 2020 19:55:13 +0000 (UTC) Subject: Re: [edk2-devel] File in the build question. I'm working on a smart git grep To: Andrew Fish , edk2-devel-groups-io References: <39884c36-c42d-8718-f14b-d638e0cd1d69@redhat.com> <1622466A6176DB37.5128@groups.io> From: "Laszlo Ersek" Message-ID: <725658cb-b4f1-0e8a-a5f8-117c4f23221d@redhat.com> Date: Mon, 20 Jul 2020 21:55:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/18/20 22:23, Andrew Fish wrote: > Wanted to see if people are OK with adding BaseTools/Scripts/ to the path when you run `. edksetuip.sh` or edksetup.bat? > > If we do that and I add BaseTools/Scripts/git-pgrep then it will show up as an extended git command. > > I was thinking over time we could add git-edk2* git commands to help automate the process or maintainer workflow. > > If people are OK with adding the path I can make a patch set to contribute git-pgrep, but I need some help with how to add the new path to edksetup.bat. To be honest, I think edksetup.sh should add BaseTools/Scripts/ to the PATH environment variable anyway. I find it a bit awkward to run python BaseTools/Scripts/GetMaintainer.py -l ... rather than just GetMaintainer.py -l ... Thanks Laszlo