Re: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

[Laszlo Ersek <lersek@redhat.com>]

On 09/19/18 03:31, Wu, Jiaxin wrote:
>>> Subject: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute
>> when opening SNP protocol installed by PXE.
>>>
>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1152
>>>
>>> v2: Sync the same logic to Ipv6 and update code comments.
>>>
>>> The PXE driver installs a SNP and open this SNP with attribute BY_DRIVER
>>> to avoid it being opened by MNP driver, this SNP is also expected not to
>>> be opened by other drivers with EXCLUSIVE attribute. In some cases, other
>>> drivers may happen to do this by error, and thus cause a system crash.
>>> This patch adds EXCLUSIVE attribute when opening SNP in PXE driver, and
>>> will reject all OpenProtocol requests by EXCLUSIVE.
>>>
>>> Cc: Subramanian, Sriram <sriram-s@hpe.com>
>>> Cc: Ye Ting <ting.ye@intel.com>
>>> Cc: Fu Siyuan <siyuan.fu@intel.com>
>>> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Wang Fan <fan.wang@intel.com>
>>> ---
>>>  NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> Either my edk2-devel subscription is breaking down, or our discipline
>> regarding commit pushing is down the drain, recently.
>>
>> This patch has been pushed as commit cde5a72d365e. Problems with that
>> commit:
>>
>> (1) The git authorship is marked as "edk2-devel-bounces@lists.01.org".
>> That's *wrong*. This patch was authored by Wang Fan
>> <fan.wang@intel.com>.
>>
> 
> Sorry Laszlo, I didn't check the "Author" field before pushing the patch as I received the commit request form Fan. I don't know whether it's the patch reason or TortoiseGit failed to fetch the "Signed-off-by" tag as "Author" field. Anyway, I will double check that. 

Thanks. You can always correct the authorship metadata with:

git commit --amend --author='Name <email@example.com>'

without staging any code changes first. (So that the patch body is not
itself modified.)

Thanks!
Laszlo