From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 403A82114399C for ; Wed, 19 Sep 2018 04:19:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC9F7307D863; Wed, 19 Sep 2018 11:19:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-175.rdu2.redhat.com [10.10.120.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 164665D97A; Wed, 19 Sep 2018 11:19:03 +0000 (UTC) To: "Wu, Jiaxin" , "Subramanian, Sriram" , "Wang, Fan" , "edk2-devel@lists.01.org" Cc: "Ye, Ting" , "Fu, Siyuan" , "Subramanian@mx0b-002e3701.pphosted.com" References: <20180914082415.800-1-fan.wang@intel.com> <895558F6EA4E3B41AC93A00D163B727416494038@SHSMSX103.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <72648195-523f-5673-5bcf-452441b163ca@redhat.com> Date: Wed, 19 Sep 2018 13:19:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <895558F6EA4E3B41AC93A00D163B727416494038@SHSMSX103.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 19 Sep 2018 11:19:05 +0000 (UTC) Subject: Re: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 11:19:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/19/18 03:31, Wu, Jiaxin wrote: >>> Subject: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute >> when opening SNP protocol installed by PXE. >>> >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1152 >>> >>> v2: Sync the same logic to Ipv6 and update code comments. >>> >>> The PXE driver installs a SNP and open this SNP with attribute BY_DRIVER >>> to avoid it being opened by MNP driver, this SNP is also expected not to >>> be opened by other drivers with EXCLUSIVE attribute. In some cases, other >>> drivers may happen to do this by error, and thus cause a system crash. >>> This patch adds EXCLUSIVE attribute when opening SNP in PXE driver, and >>> will reject all OpenProtocol requests by EXCLUSIVE. >>> >>> Cc: Subramanian, Sriram >>> Cc: Ye Ting >>> Cc: Fu Siyuan >>> Cc: Wu Jiaxin >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Wang Fan >>> --- >>> NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> Either my edk2-devel subscription is breaking down, or our discipline >> regarding commit pushing is down the drain, recently. >> >> This patch has been pushed as commit cde5a72d365e. Problems with that >> commit: >> >> (1) The git authorship is marked as "edk2-devel-bounces@lists.01.org". >> That's *wrong*. This patch was authored by Wang Fan >> . >> > > Sorry Laszlo, I didn't check the "Author" field before pushing the patch as I received the commit request form Fan. I don't know whether it's the patch reason or TortoiseGit failed to fetch the "Signed-off-by" tag as "Author" field. Anyway, I will double check that. Thanks. You can always correct the authorship metadata with: git commit --amend --author='Name ' without staging any code changes first. (So that the patch body is not itself modified.) Thanks! Laszlo