From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.9405.1615386016630375265 for ; Wed, 10 Mar 2021 06:20:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cbCkSqSh; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615386015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zRtZHQMqYKyTkZA4E2HbJTi3gErd+FynsX5q0yJtZAU=; b=cbCkSqShKodrywNvbfeIzJi/qNd8OkZ42lDYjA29kMAqi3L9I4XLb6jHzchihXrY5KGuNF LFHiHFqG9tLF+e5PbbHgBWiw3CbtoMoweNqQc3K2/xsbbUA8CNr4Akeq5PWZAOBTFwzmRp 4kVXblqzDpFb/uarQNdVIX9htwi7Fpo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-aDTLT4qUMRefAm8L-DEtVw-1; Wed, 10 Mar 2021 09:20:11 -0500 X-MC-Unique: aDTLT4qUMRefAm8L-DEtVw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CEBA26870; Wed, 10 Mar 2021 14:20:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-138.ams2.redhat.com [10.36.115.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05B4F101E24A; Wed, 10 Mar 2021 14:20:06 +0000 (UTC) Subject: Re: [PATCH 2/2] Maintainers.txt: Add reviewers for Confidential Computing related modules To: Min Xu , Jiewen Yao , James Bottomley , Brijesh Singh , Tom Lendacky Cc: devel@edk2.groups.io, Andrew Fish , Leif Lindholm , Michael D Kinney References: <20210310025532.2108-1-min.m.xu@intel.com> <20210310025532.2108-3-min.m.xu@intel.com> From: "Laszlo Ersek" Message-ID: <72834ef3-8916-3364-4942-9cc24e4e1d21@redhat.com> Date: Wed, 10 Mar 2021 15:20:06 +0100 MIME-Version: 1.0 In-Reply-To: <20210310025532.2108-3-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Adding James, Brijesh, Tom; comments below: On 03/10/21 03:55, Min Xu wrote: > Register reviewers for the Confidential Computing related modules in > OvmfPkg. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Jiewen Yao > Signed-off-by: Min Xu > --- > Maintainers.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 7d9fe89d6d28..220af0ee9b80 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -469,6 +469,9 @@ OvmfPkg: TDX-related modules > R: Jiewen Yao > R: Min Xu > > +OvmfPkg: Confidential Computing related modules > +R: Jiewen Yao > + > OvmfPkg: TCG- and TPM2-related modules > F: OvmfPkg/Include/IndustryStandard/QemuTpm.h > F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > (1) Same comment as under patch#1 -- please honor the alphabetical ordering of the subsystem titles. (2) Reviewing this patch makes me realize we've missed some "Maintainers.txt" updates in the past, in relation to SEV and/or confidential computing. Namely, we did not designated any reviewers for the following pathnames: OvmfPkg/AmdSev/ OvmfPkg/Include/Guid/ConfidentialComputingSecret.h OvmfPkg/Library/PlatformBootManagerLibGrub/ (from ), also OvmfPkg/ResetVector/ (from ). That should be fixed up before adding anything TDX related (I can submit a patch series, but first, the next point needs to be cleared.) (3) After racking my brain for half an hour, I can find no good way to have TDX/SEV separation *plus* a Confidential Computing section in "Maintainers.txt". Whatever I managed to think of requires us to either duplicate email addresses, or duplicate pathnames ("F:" patterns) -- or even both. So... can we simply rename the current SEV subsystem to "Confidential Computing", and keep both TDX and SEV modules under it? We could place a unified email address list there, with Brijesh, James, Jiewen, Min, Tom. I don't think this should cause any confusion, because: - @intel.com emails are clearly closely associated with TDX, and @amd.com emails are clearly closely associated with SEV, - most filenames will (or do already) include "AmdSev" or "Tdx", - future patches should clearly label themselves as "SEV only", "TDX only", or "confidential computing in general" -- this should be clear from the patch subjects. IOW, there should be no confusion as to who's required to review what, but at the same time we'd have a simple solution for cross-posting all interested parties. Thoughts? Thanks, Laszlo