From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 07/24] DynamicTablesPkg: Remove duplicated words
Date: Tue, 23 Aug 2022 18:09:50 +0100 [thread overview]
Message-ID: <729e004f-44e0-c91f-d224-633240c5b434@arm.com> (raw)
In-Reply-To: <20220823160031.991072-8-Pierre.Gondois@arm.com>
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> DynamicTablesPkg/Include/Library/HwInfoParserLib.h | 2 +-
> .../Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 +-
> .../Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/AmlNodeDefines.h | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.h | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +-
> DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c | 2 +-
> .../Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 2 +-
> .../Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/DynamicTablesPkg/Include/Library/HwInfoParserLib.h b/DynamicTablesPkg/Include/Library/HwInfoParserLib.h
> index 05c21aeac00a..9710f7466170 100644
> --- a/DynamicTablesPkg/Include/Library/HwInfoParserLib.h
> +++ b/DynamicTablesPkg/Include/Library/HwInfoParserLib.h
> @@ -83,7 +83,7 @@ HwInfoParse (
> );
>
> /** Cleanup any internal state and resources that were allocated
> - by the the HwInfoParser.
> + by the HwInfoParser.
>
> @param [in] ParserHandle A handle to the parser instance.
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> index 18c8b8d24525..b990686d40a3 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> @@ -587,7 +587,7 @@ BuildSsdtCmn600TableEx (
> return Status;
> }
>
> - // Setup the table list early so that that appropriate cleanup
> + // Setup the table list early so that appropriate cleanup
> // can be done in case of failure.
> *Table = TableList;
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> index 39cfbad95926..b850320eede7 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> @@ -239,7 +239,7 @@ BuildSsdtSerialPortTableEx (
> return Status;
> }
>
> - // Setup the table list early so that that appropriate cleanup
> + // Setup the table list early so that appropriate cleanup
> // can be done in case of failure.
> *Table = TableList;
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlNodeDefines.h b/DynamicTablesPkg/Library/Common/AmlLib/AmlNodeDefines.h
> index 8ceb20ff415e..d199f06cc54d 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlNodeDefines.h
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlNodeDefines.h
> @@ -34,7 +34,7 @@ typedef AML_NODE_HEADER *AML_NODE_HANDLE;
>
> /** AML root node.
>
> - The root node is unique and at the head of of tree. It is a fake node used
> + The root node is unique and at the head of tree. It is a fake node used
> to maintain the list of AML statements (stored as object nodes) which are
> at the first scope level.
> */
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.c b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.c
> index 391c72bd322e..8f460a972841 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.c
> @@ -27,7 +27,7 @@
> of NameSegs that have less that 4 chars, like "DEV". "DEV" will be expanded
> as "DEV_".
>
> - An AML NameString is not NULL terminated and is is only composed of
> + An AML NameString is not NULL terminated and is only composed of
> 4 chars long NameSegs.
>
> @param [in] NameOpNode NameOp object node defining a variable.
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.h b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.h
> index 8bbf62bbcd24..2b4c60d3ee14 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.h
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApiHelper.h
> @@ -19,7 +19,7 @@
> of NameSegs that have less that 4 chars, like "DEV". "DEV" will be expanded
> as "DEV_".
>
> - An AML NameString is not NULL terminated and is is only composed of
> + An AML NameString is not NULL terminated and is only composed of
> 4 chars long NameSegs.
>
> @param [in] NameOpNode NameOp object node defining a variable.
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> index e51d2dd7f083..12b6ef62f5cd 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> @@ -1071,7 +1071,7 @@ AmlAddPrtEntry (
> goto error_handler;
> }
>
> - // Append to the the list of _PRT entries.
> + // Append to the list of _PRT entries.
> Status = AmlVarListAddTail (
> (AML_NODE_HANDLE)PrtEntryList,
> (AML_NODE_HANDLE)PackageNode
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c
> index 35e34e765f71..376de078bcb1 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParser.c
> @@ -168,7 +168,7 @@ HwInfoParse (
> }
>
> /** Cleanup any internal state and resources that were allocated
> - by the the HwInfoParser.
> + by the HwInfoParser.
>
> @param [in] ParserHandle A handle to the parser instance.
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
> index 831f0d5b7365..1f3af1f968a9 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
> @@ -130,7 +130,7 @@ ArmGicDispatcher (
>
> Fdt = FdtParserHandle->Fdt;
>
> - // The "cpus" node resides at the the root of the DT. Fetch it.
> + // The "cpus" node resides at the root of the DT. Fetch it.
> CpusNode = fdt_path_offset (Fdt, "/cpus");
> if (CpusNode < 0) {
> return EFI_NOT_FOUND;
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
> index 0557e416b44c..cfd032df4d74 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
> @@ -278,7 +278,7 @@ GetSerialConsoleNode (
> return EFI_INVALID_PARAMETER;
> }
>
> - // The "chosen" node resides at the the root of the DT. Fetch it.
> + // The "chosen" node resides at the root of the DT. Fetch it.
> ChosenNode = fdt_path_offset (Fdt, "/chosen");
> if (ChosenNode < 0) {
> return EFI_NOT_FOUND;
next prev parent reply other threads:[~2022-08-23 17:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09 ` Sami Mujawar [this message]
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29 ` Leif Lindholm
2022-08-24 13:31 ` Chang, Abner
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55 ` Chiu, Chasel
2022-09-01 23:18 ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24 ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31 ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32 ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24 5:34 ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24 0:50 ` Wu, Hao A
2022-08-24 1:06 ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11 ` Sami Mujawar
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25 3:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=729e004f-44e0-c91f-d224-633240c5b434@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox