From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 06 Jun 2019 10:09:36 -0700
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 8908A3082E03;
	Thu,  6 Jun 2019 17:09:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-49.ams2.redhat.com [10.36.116.49])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 6658512A66;
	Thu,  6 Jun 2019 17:09:19 +0000 (UTC)
Subject: Re: [PATCH v2 2/4] ArmVirtPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Julien Grall <julien.grall@arm.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Leif Lindholm <leif.lindholm@linaro.org>, Jian J Wang
 <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
 Star Zeng <star.zeng@intel.com>
References: <20190606131459.1464-1-anthony.perard@citrix.com>
 <20190606131459.1464-3-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <72a0591b-4b7d-1861-84b2-80e784741880@redhat.com>
Date: Thu, 6 Jun 2019 19:09:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190606131459.1464-3-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 06 Jun 2019 17:09:28 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/06/19 15:14, Anthony PERARD wrote:
> SERIAL_DXE_FILE_GUID is now defined in MdeModulePkg as
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID, simply use it.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b8f50ea96b..30c015eec5 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -26,6 +26,7 @@
>  #include <Protocol/VirtioDevice.h>
>  #include <Guid/EventGroup.h>
>  #include <Guid/RootBridgesConnectedEventGroup.h>
> +#include <Guid/SerialPortLibVendor.h>
>  
>  #include "PlatformBm.h"
>  
> @@ -41,18 +42,13 @@ typedef struct {
>  } PLATFORM_SERIAL_CONSOLE;
>  #pragma pack ()
>  
> -#define SERIAL_DXE_FILE_GUID { \
> -          0xD3987D4B, 0x971A, 0x435F, \
> -          { 0x8C, 0xAF, 0x49, 0x67, 0xEB, 0x62, 0x72, 0x41 } \
> -          }
> -
>  STATIC PLATFORM_SERIAL_CONSOLE mSerialConsole = {
>    //
>    // VENDOR_DEVICE_PATH SerialDxe
>    //
>    {
>      { HARDWARE_DEVICE_PATH, HW_VENDOR_DP, DP_NODE_LEN (VENDOR_DEVICE_PATH) },
> -    SERIAL_DXE_FILE_GUID
> +    EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>    },
>  
>    //
> 

I would drop "from MdeModulePkg" from the subject line. With that change,

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

If the maintainer that pushes this series agrees to tweak the subject
like that, then I'm OK if the series is not reposted just for this. (BTW
I could be that maintainer too.)

Thanks
Laszlo