From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH v6 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list
Date: Fri, 24 Mar 2023 18:33:35 -0400 [thread overview]
Message-ID: <72b6fb26-dede-1ea2-b36f-b91b36962c10@linux.microsoft.com> (raw)
In-Reply-To: <71c0f0e1-2e22-0531-d036-b70d6fa94f88@linux.microsoft.com>
The changes are merged in the v7 series:
https://edk2.groups.io/g/devel/message/101846
On 3/24/2023 5:27 PM, Michael Kubacki wrote:
> Yes, no problem. Thanks for bringing this to my attention.
>
> On 3/24/2023 4:56 PM, Rebecca Cran wrote:
>> Ah, but my patch was only for Makefiles: I didn't realize source files
>> also contain tabs.
>>
>> So we probably want a combination of our patches: yours to ignore the
>> entire directory, and the change I made to also ignore files named
>> "makefile" as well as "Makefile".
>>
>> Could you update your patch with my
>> "os.path.basename(self.filename).lower() == 'makefile' " change please?
>>
>>
next prev parent reply other threads:[~2023-03-24 22:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:48 [PATCH v6 00/12] Enable New CodeQL Queries Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 01/12] MdeModulePkg/SmbiosDxe: Fix pointer and buffer overflow CodeQL alerts Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list Michael Kubacki
2023-03-24 20:52 ` [edk2-devel] " Rebecca Cran
[not found] ` <174F7634AC74F535.7603@groups.io>
2023-03-24 20:56 ` Rebecca Cran
2023-03-24 21:27 ` Michael Kubacki
2023-03-24 22:33 ` Michael Kubacki [this message]
2023-03-24 20:48 ` [PATCH v6 03/12] BaseTools/VfrCompile: Fix potential buffer overwrites Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 04/12] CryptoPkg: Fix conditionally uninitialized variable Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 05/12] MdeModulePkg: Fix conditionally uninitialized variables Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 06/12] MdePkg: " Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 07/12] NetworkPkg: " Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 08/12] PcAtChipsetPkg: " Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 09/12] ShellPkg: " Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 10/12] UefiCpuPkg: " Michael Kubacki
2023-03-24 21:16 ` Michael D Kinney
2023-03-24 20:48 ` [PATCH v6 11/12] .github/codeql/edk2.qls: Enable CWE 457, 676, and 758 queries Michael Kubacki
2023-03-24 20:48 ` [PATCH v6 12/12] .github/codeql/edk2.qls: Enable CWE 120, 787, and 805 queries Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b6fb26-dede-1ea2-b36f-b91b36962c10@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox