From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.10603.1679697218077677495
 for <devel@edk2.groups.io>;
 Fri, 24 Mar 2023 15:33:38 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=dAsMLHxV;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id ED38320FC3CF;
	Fri, 24 Mar 2023 15:33:36 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED38320FC3CF
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1679697217;
	bh=LR00YJl8l3ikZIfhy++jXsh+VNoj5KJlbmJX5OkI5cM=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=dAsMLHxVRGWbDwAd0w2i9tvPEyTV0U02grZ80QixTCrAFACa1vvFFPjNVRdU3i0XD
	 a3gPWku6RfRWFkVindkiSdJ3eEdVCSi1W2m8S2Ap76aJEHLKIzKwAwnJvcIwfd2CvA
	 6psfwO1k6Ks0nvKWNYj+4kaeeZCWsZ45inBH4S9o=
Message-ID: <72b6fb26-dede-1ea2-b36f-b91b36962c10@linux.microsoft.com>
Date: Fri, 24 Mar 2023 18:33:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [edk2-devel] [PATCH v6 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>, Yuwei Chen <yuwei.chen@intel.com>
References: <20230324204838.1485-1-mikuback@linux.microsoft.com>
 <20230324204838.1485-3-mikuback@linux.microsoft.com>
 <174F7634AC74F535.7603@groups.io>
 <5ec2b49b-c6a7-df8e-66fe-900598422c1d@bsdio.com>
 <71c0f0e1-2e22-0531-d036-b70d6fa94f88@linux.microsoft.com>
In-Reply-To: <71c0f0e1-2e22-0531-d036-b70d6fa94f88@linux.microsoft.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

The changes are merged in the v7 series:
https://edk2.groups.io/g/devel/message/101846


On 3/24/2023 5:27 PM, Michael Kubacki wrote:
> Yes, no problem. Thanks for bringing this to my attention.
> 
> On 3/24/2023 4:56 PM, Rebecca Cran wrote:
>> Ah, but my patch was only for Makefiles: I didn't realize source files 
>> also contain tabs.
>>
>> So we probably want a combination of our patches: yours to ignore the 
>> entire directory, and the change I made to also ignore files named 
>> "makefile" as well as "Makefile".
>>
>> Could you update your patch with my 
>> "os.path.basename(self.filename).lower() == 'makefile' " change please?
>>
>>