From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.8209.1625587027342927502 for ; Tue, 06 Jul 2021 08:57:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IxfsXoOl; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625587026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrOny4/AFVL7AuY/KBQGZjyu1baZ7y+f+vc91SzBW08=; b=IxfsXoOl6b1WYGLEub0Z58vx/wsoGvMeXR2H0LdYm/W3suy4M9SqXNmMSL2xld4mViRy9q B/hAt32LQMRzA1Pk10XllZsLVRBjwl4sZUKvfUVuSz6XmG7V5+MF4E9RZ5MzHrL22NoRb5 g0y7IPpOMfA+6ajFPIdqLCRDW7WnZoQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-W0bx2W6UOVioQwEJigP0vg-1; Tue, 06 Jul 2021 11:57:05 -0400 X-MC-Unique: W0bx2W6UOVioQwEJigP0vg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 066FF8015F5; Tue, 6 Jul 2021 15:57:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-54.ams2.redhat.com [10.36.113.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ABCE19D9D; Tue, 6 Jul 2021 15:57:02 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment To: devel@edk2.groups.io, philmd@redhat.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Julien Grall References: <20210706094925.1107407-1-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: <72c07b27-73d4-b25a-12d7-e309f5dc5dce@redhat.com> Date: Tue, 6 Jul 2021 17:57:01 +0200 MIME-Version: 1.0 In-Reply-To: <20210706094925.1107407-1-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/06/21 11:49, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > The "Shell Embedded Boot Loader" description (added in > commit 6f5872b1f401) does not add any value, remove it. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Julien Grall > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/ArmVirtKvmTool.fdf | 2 +- > ArmVirtPkg/ArmVirtXen.fdf | 2 +- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index d9abadbe708c..e17238e63803 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -376,7 +376,7 @@ [Components.common] > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > # > - # UEFI application (Shell Embedded Boot Loader) > + # UEFI application > # > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf > index 076155199905..8ad67233dc90 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.fdf > +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf > @@ -174,7 +174,7 @@ [FV.FvMain] > INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > > # > - # UEFI application (Shell Embedded Boot Loader) > + # UEFI application > # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index 8fbbc2313aff..bab4af446cfb 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -178,7 +178,7 @@ [FV.FvMain] > INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > # > - # UEFI application (Shell Embedded Boot Loader) > + # UEFI application > # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index 5b1d10057545..5ecde9233951 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -100,7 +100,7 @@ [FV.FvMain] > INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > > # > - # UEFI application (Shell Embedded Boot Loader) > + # UEFI application > # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > I'm really sorry Phil, but even the new comment looks just super weird to me. I've grepped the edk2 codebase for "ShellPkg/Application/Shell/Shell.inf", and looked at the leading context (approx. 30 lines) near every match -- and now I actually think we don't need *any* comments here. I mean we could say "UEFI Shell Application", but is that really helpful? I have no idea. I'll let other ArmVirtPkg reviewers comment on this. Thanks Laszlo