From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: solarflare.com, ip: 67.231.154.164, mailfrom: tpilar@solarflare.com) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by groups.io with SMTP; Mon, 24 Jun 2019 04:24:20 -0700 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2A576B4006B; Mon, 24 Jun 2019 11:24:19 +0000 (UTC) Received: from tp-desktop.uk.solarflarecom.com (10.17.20.51) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 24 Jun 2019 04:24:15 -0700 Subject: Re: [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds To: Ard Biesheuvel CC: Devel EDK2 , "jordan.l.justen@intel.com" , "lersek@redhat.com" References: <65b0c09f4296451484f671223fe6b6af@ukex01.SolarFlarecom.com> From: "Tomas Pilar (tpilar)" Message-ID: <72cb7134-d04c-cde6-e028-83e4cb94aa94@solarflare.com> Date: Mon, 24 Jun 2019 12:24:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.17.20.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24708.005 X-TM-AS-Result: No-11.111900-4.000000-10 X-TMASE-MatchedRID: X4bcv0S75KkikhyG+/kfavZvT2zYoYOwC/ExpXrHizw/hcT28SJs8t+K HOWxZSzSAqKoQr0HqHs7KCG9nVePbJvpe1MTgRlkhjlBjwpom1N/9Mg6o+wMiziuMlzVheGwrkd 4yEVTr24YzGbvuRy4HlA/EVKkkwZPtRMdYTLHCC4ylU6xjA3vwz0oG3q2fIVyR2YNIFh+clF2HF ZouXfsn6oe9ycwfgLuRj8ugvyJmEMXbLU2BlsHrYpHR9xEGhE1gcsVZH3dOCSedhlcFdTxL6Lml xP63kmZrPSDIIvNFr2D+uioEcvSQnyuXBiUcuzxCuDAUX+yO6aWODD/yzpvdwdkFovAReUogpJH uODTmwWGySSoMU8pP5GTpe1iiCJq71zr0FZRMbBWdFebWIc3VsRB0bsfrpPIFT1PBs+MVY2l/Mt rTwS4UAEvYfPwQNYeyrHpHYY5bB/MtQzgJVlSUvdXvmOT1oJFp9Xk0+B4muk= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.111900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24708.005 X-MDID: 1561375459-Z_pFjMVsxgCU Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US On 24/06/2019 12:15, Ard Biesheuvel wrote: > On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: >> Switching to this library enables capsule support for FMP devices. Simple >> tests show that a capsule with an embedded driver now updates using >> CapsuleApp. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Signed-off-by: Tomas Pilar > I don't have a problem with this change unless it affects the code > size considerably. > > However, isn't this only useful for updating the firmware on PCI cards > from within a VM when they are passed through from the host to the > guest? I understand this is a useful test scenario for you, but at > least clarify this in the commit log. The library itself is tiny. The use case you describe is exactly what I am using at the moment. I can imagine that software testing FMP implementation APIs is also something that might be useful. I will clarify in the commit. > >> --- >> OvmfPkg/OvmfPkgX64.dsc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index 39ac791565..4c41e59a75 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -125,7 +125,7 @@ >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> - CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf >> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf >> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf >> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf >> -- >> 2.17.2 >>