From: "Laszlo Ersek" <lersek@redhat.com>
To: Ashish Singhal <ashishsingha@nvidia.com>, Andrew Fish <afish@apple.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ni, Ray" <ray.ni@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
Mike Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration
Date: Tue, 5 Nov 2019 20:23:34 +0100 [thread overview]
Message-ID: <72ce1d71-2a65-a6c0-1dd8-7628429c5a3c@redhat.com> (raw)
In-Reply-To: <DM6PR12MB3324C021FE6B4EEB8B3AFAB8BA7E0@DM6PR12MB3324.namprd12.prod.outlook.com>
On 11/05/19 19:00, Ashish Singhal wrote:
> I agree that I can use the platform boot manager protocol to modify
> the boot variable and give the custom optional data I need, but that
> would not stop UefiBootManagerLib from creating another boot option
> with mBmAutoCreateBootOptionGuid as the optional data on the next
> bootup which I would have to delete every time in the platform boot
> manager driver.
>From a purely pragmatic perspective, I would act exactly like you
describe above. I'm not saying that this is the cleanest design, or that
it has the best performance. However, it also does not introduce
technical debt -- it's not a "wrong" thing to do --, and (from past
experience) keeping it 100% in platform code produces the least amount
of friction, and allows for the smoothest development. Extending
UefiBootManagerLib has always been an uphill battle.
Thanks
Laszlo
next prev parent reply other threads:[~2019-11-05 19:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 3:47 [PATCH] Support skipping automatic BM enumeration Ashish Singhal
2019-10-30 3:47 ` [PATCH] MdeModulePkg/UefiBootManagerLib: Support skipping " Ashish Singhal
2019-10-31 10:14 ` [edk2-devel] [PATCH] Support skipping automatic " Laszlo Ersek
[not found] ` <DM6PR12MB33249A87560B32B0155D4FE0BA630@DM6PR12MB3324.namprd12.prod.outlook.com>
2019-11-01 21:42 ` Laszlo Ersek
2019-11-01 22:05 ` Ashish Singhal
2019-11-01 22:57 ` Laszlo Ersek
2019-11-04 17:51 ` Ashish Singhal
2019-11-05 2:42 ` Ni, Ray
2019-11-05 3:24 ` Ashish Singhal
2019-11-05 5:00 ` Andrew Fish
2019-11-05 5:06 ` Ashish Singhal
2019-11-05 5:21 ` Andrew Fish
2019-11-05 5:42 ` Ashish Singhal
2019-11-05 6:15 ` Andrew Fish
2019-11-05 9:54 ` Laszlo Ersek
2019-11-05 16:52 ` Andrew Fish
2019-11-05 18:00 ` Ashish Singhal
2019-11-05 19:23 ` Laszlo Ersek [this message]
2019-11-05 23:19 ` Jeff Brasen
2019-11-06 0:20 ` Andrew Fish
2019-11-06 9:56 ` Laszlo Ersek
2019-11-06 16:15 ` Andrew Fish
2019-11-06 19:58 ` Laszlo Ersek
2019-11-06 1:07 ` Ashish Singhal
2019-11-06 1:34 ` Jeff Brasen
2019-11-06 2:47 ` Andrew Fish
2019-11-06 3:20 ` Ni, Ray
2019-11-06 16:19 ` Andrew Fish
2019-11-07 4:12 ` Jeff Brasen
2019-11-07 6:59 ` Ni, Ray
2019-11-07 7:02 ` Jeff Brasen
2019-11-07 7:21 ` Ni, Ray
2019-11-07 17:46 ` Jeff Brasen
2019-11-08 16:37 ` Laszlo Ersek
2019-11-11 22:57 ` Jeff Brasen
2019-11-11 23:58 ` Ni, Ray
2019-11-12 0:00 ` Jeff Brasen
2019-11-13 18:42 ` Jeff Brasen
2019-11-14 2:09 ` Ni, Ray
2019-11-14 17:04 ` Jeff Brasen
2019-12-10 20:46 ` Jeff Brasen
2019-12-11 9:54 ` [edk2-discuss] " Wang, Sunny (HPS SW)
2019-12-11 14:00 ` Ni, Ray
2019-12-12 17:52 ` Jeff Brasen
2019-12-17 20:15 ` Ashish Singhal
2019-12-18 3:54 ` [edk2-discuss] " Wang, Sunny (HPS SW)
2019-12-18 8:43 ` Ni, Ray
2019-11-07 7:01 ` Ni, Ray
2019-11-05 9:33 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ce1d71-2a65-a6c0-1dd8-7628429c5a3c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox