From: Laszlo Ersek <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
Date: Thu, 16 Aug 2018 20:23:03 +0200 [thread overview]
Message-ID: <72d0a91a-a67c-18b4-9767-7210d1e678d9@redhat.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2E3A45@SHSMSX104.ccr.corp.intel.com>
On 08/15/18 19:37, Gao, Liming wrote:
> Laszlo:
> The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks!
Pushed as commit range 9becf2f0759e..81502cee20ac.
Laszlo
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Wednesday, August 15, 2018 10:19 AM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
>>
>> Hi Liming,
>>
>> On 08/09/18 15:22, Laszlo Ersek wrote:
>>> Repo: https://github.com/lersek/edk2.git
>>> Branch: extra_flags_rhbz1540244_v2
>>>
>>> Version 1 of this set was posted at
>>>
>>> http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
>>> https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
>>>
>>> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
>>> generator and the "antlr" parser generator) are not modified. Relative
>>> to v1:
>>>
>>> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
>>> been dropped,
>>>
>>> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
>>> "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
>>> and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
>>> caller".
>>>
>>> In other words, v2 is a proper subset of v1, so that PCCTS is left
>>> alone.
>>>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>>
>> do you have any comments on patches #4 and #5?
>>
>> Thanks,
>> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
prev parent reply other threads:[~2018-08-16 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 13:22 [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller Laszlo Ersek
2018-08-09 13:22 ` [PATCH v2 1/5] BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too Laszlo Ersek
2018-08-09 13:22 ` [PATCH v2 2/5] BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS Laszlo Ersek
2018-08-09 13:22 ` [PATCH v2 3/5] BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS Laszlo Ersek
2018-08-09 13:22 ` [PATCH v2 4/5] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller Laszlo Ersek
2018-08-09 13:22 ` [PATCH v2 5/5] BaseTools/Source/C: take EXTRA_LDFLAGS " Laszlo Ersek
2018-08-15 17:19 ` [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and " Laszlo Ersek
2018-08-15 17:37 ` Gao, Liming
2018-08-16 18:23 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d0a91a-a67c-18b4-9767-7210d1e678d9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox