From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D5FC21962301 for ; Thu, 16 Aug 2018 11:23:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D745D40201C6; Thu, 16 Aug 2018 18:23:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-198.rdu2.redhat.com [10.10.120.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55A4520180F4; Thu, 16 Aug 2018 18:23:04 +0000 (UTC) To: "Gao, Liming" Cc: edk2-devel-01 References: <20180809132258.21874-1-lersek@redhat.com> <67ba2d48-e31f-92c5-e7bd-4453b4899b61@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2E3A45@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <72d0a91a-a67c-18b4-9767-7210d1e678d9@redhat.com> Date: Thu, 16 Aug 2018 20:23:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2E3A45@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 16 Aug 2018 18:23:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 16 Aug 2018 18:23:04 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 18:23:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/15/18 19:37, Gao, Liming wrote: > Laszlo: > The patch is good. Reviewed-by: Liming Gao Thanks! Pushed as commit range 9becf2f0759e..81502cee20ac. Laszlo > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, August 15, 2018 10:19 AM >> To: Gao, Liming >> Cc: edk2-devel-01 >> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller >> >> Hi Liming, >> >> On 08/09/18 15:22, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: extra_flags_rhbz1540244_v2 >>> >>> Version 1 of this set was posted at >>> >>> http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com >>> https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html >>> >>> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer >>> generator and the "antlr" parser generator) are not modified. Relative >>> to v1: >>> >>> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has >>> been dropped, >>> >>> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from >>> "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller" >>> and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the >>> caller". >>> >>> In other words, v2 is a proper subset of v1, so that PCCTS is left >>> alone. >>> >>> Cc: Liming Gao >>> Cc: Yonghong Zhu >> >> do you have any comments on patches #4 and #5? >> >> Thanks, >> Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >