From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.46]) by mx.groups.io with SMTP id smtpd.web11.20.1634241112648343987 for ; Thu, 14 Oct 2021 12:51:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=O3Tnl02c; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.46, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXjjdsSJH7pvYQJtnmBnFI/KtHisRs1S23VITSabEdWEZyON1jpR9Ig8SxChY7yfNpO7egn7RbVzYv6nM1ovHWNl4MSdozYUiQ2QU1I7alr3xvrkZ/O1/EpwPEH4vG2lbpIAaG9mfoxwB8FMSNsA2ZGrZjcPutYyYo6oUYCjvJNmUIIXsxiuK169DDJWu5lP+XmiOYGGqIbH5Utk2qzb3swd699jqXKBHJd61NVQ2f0I1LLPqf4IOVW6Z2NRYwu4zuwb35W+pp6r5UnjPermWjloqzaLYXdFkmaoXvDMca5DN3hAfn6uUzjcOh1FuWUZ5uzeAIWQICpntOg+fXsI1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y3MTNzJvjwXevSxyF/iJ75BeVn3C9YrMHeF31Wfhuqc=; b=nYp58u6TRNc3c9VgPJNrV6aS7yMI3CcD8bhrKG+dc+C7lo6ZhGffWewcPGYiJw1COwvRgmvGrcJVe4OKXc1NDNYHDE2eAYnCJN0nR82P1EzEqiQs1PpWNms05BcA/1EHvLWA+0+BZvduSDq1hrkjeMY1cM40/Y97JxAw1aBA4xLVDRu5qFM1T4w/yBanLHT6VXz64nyxoZI4KI/Nl3ObyTrNDQz7VfWNii0pjw7U8qJ3y/BgYIbaIhPcsyLQo1H/FJSzHivB6iKwF1AQe80cCWpgePHFrNGwTgQOn+Hpg/xmP4IxcusZuxMUjr2ICODNIbcoV7lX+KSCOVLoqN5ZMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y3MTNzJvjwXevSxyF/iJ75BeVn3C9YrMHeF31Wfhuqc=; b=O3Tnl02cy6AMW3YATaW7aZUvJu1UuCDUiUZToDZU1svT/JX6ZRJear8BTMl5kRtxCRCjAlyaJUZgh8n0ELFp7vRSnsiv4L5rE5AdhnJchJLo3q+996p45yAO/k40T1ysYSUbinvavEi4AljT/xp/rV23p8403R30H/qyQabw2Jk= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4590.namprd12.prod.outlook.com (2603:10b6:806:93::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 19:51:51 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 19:51:51 +0000 Cc: brijesh.singh@amd.com, devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth Subject: Re: [PATCH v9 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use To: Gerd Hoffmann References: <20211013165713.727815-1-brijesh.singh@amd.com> <20211013165713.727815-5-brijesh.singh@amd.com> <20211014070832.sy2ezblvl6olpbtd@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: <72e8129a-4e9a-0914-6c4f-879e3b53ff5a@amd.com> Date: Thu, 14 Oct 2021 14:51:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211014070832.sy2ezblvl6olpbtd@sirius.home.kraxel.org> X-ClientProxiedBy: SA9PR13CA0001.namprd13.prod.outlook.com (2603:10b6:806:21::6) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.78.25) by SA9PR13CA0001.namprd13.prod.outlook.com (2603:10b6:806:21::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.9 via Frontend Transport; Thu, 14 Oct 2021 19:51:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3b28e35-4a37-40c6-b4b0-08d98f4c108a X-MS-TrafficTypeDiagnostic: SA0PR12MB4590: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gcZCabnlJ/GS3boy7QFdgsaN1izwK8WSEcfiBtmniQgR0YYlvTkrPOZ5AejijHNyqUgElTAMw+BcmcVt2/BVFelmqyXdcL11i474Z31dkJ/3qtfamlK5zqMmvTWglgcYwt9ZdOdne+DZvFA/+orGqsFusDZPx179OBHSfecoAyVgPe7ydNakTcetwaOeXkG7Park18qU7yhr5LddgIWiZrvthwhsRKrFWChK3X/VOd07rFBSrUcIlbq1hJL6grTZfn9+ZCeUDwnkhPq9WzpdyHfwGJUaXVKWJH77umpiZ8grulzNcc/PYwJy/FPwYJDIVwF7lEOHInI+hKF6ethZzoQiiWDiKb8TxhYQkdRmUSke2x2QnVpEt6T/B6sBIb6FaJ6OLl678pevwhz+xPGBGfTfmfyPO682kWuCdKNhwKwoVzsP/uaAge5RCweC79Uh1WuIpzcy4dEIDBwaVoVGcDoktC2A300dov8qTPKj+3CwuATJod6UT0axlZHFnpQD/Ex4NMMwkZcKwRL8GDY09edPxnqQs9+bVVppyzRzBK6mvz15CE6VlfulDuHxZma6NwxvmpKPFeZNDRr6GoD/JrOG/8NXS26MGl/lPvXP8fSvbO1vDlYMUhZH0YzlfnZJZNvybR9aysn9Dkfq/HfNgbISHtSrOvkjKvSVgUPZpZhkOIexTXQWjDGGMQIaOW0xTie7UgC1Ilrp7TFZun2YQAxt666R0G3rURXuW9OZjdkEpehD1iHfa6996hrlNUfgamOcQUZ44js1VX67qik/H38/4PivnFY1c76ioX3Wxa57gKw+5tMP0j57fVt1Hmr5aSl2WKPkLbnSN0NwefvY8g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(956004)(316002)(2906002)(44832011)(66556008)(66476007)(45080400002)(31686004)(26005)(54906003)(6486002)(5660300002)(4326008)(186003)(38100700002)(8676002)(86362001)(6506007)(53546011)(6512007)(83380400001)(6916009)(66946007)(36756003)(508600001)(2616005)(966005)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXg4NWtCeXVFRDdXcWhGcW55K0NlZGRDakp1NFNTbUVZQXkzZmE3Y25WWFRD?= =?utf-8?B?OXQvU2lzSUlYNjRsanpOb3NFbTRXRU9EM1pVaVZtSU1PdU1OMHpLM3QvNzFQ?= =?utf-8?B?ZVp2MEFSWHJaUGFUNkx0alpLZmxka0tXWTdEaitLOWNwWjM0QVpMazQrYWV0?= =?utf-8?B?aHVjVTQraVhwSWFOSFNYdFRreUVKZHI4S3A3OC9IUXlYa2s3bnMzNlV6Sm1I?= =?utf-8?B?RnErNVovK0I2Z3VmOUNNN2dIc0lHL0JVR2YwS1NGZVlzSHM5emY4NW5oRHNK?= =?utf-8?B?RVM0RHlIdjBnTHlxdWNXRlBIMGtoQ1h3QXFiOFZNcVhMVWM1eHBXNnhMSHJ2?= =?utf-8?B?ZUQ1RG1mbXBSMEJVOVVLK0pVcUZyekViSXpBeVNlUlRNYXF2RUlIS1dUKzZu?= =?utf-8?B?ck52Y21VNzd3NFpnaWE1dFgrR0U5aG96NFdlK0NIa1hoVkoycGJPeTA1VUty?= =?utf-8?B?SlN3UzltZXZtU3BBa3Q3bEptVmxYbTNIV2lxTW9vUWlCUFhNdnlIU3VEVU9P?= =?utf-8?B?K253bFh1QVl1WFFIWHA0MmFBTVc3MStaazhxWnNleUtOcnp0UGpqeGw5cUEz?= =?utf-8?B?eGl3ektSdHFsMTJYZ1c5aHhVUXBFOUloUEp0anczQ3FGbko0MEtJYlM4d0pT?= =?utf-8?B?ZWZ2c2lyMlNVSGhvOUkxQ21keTFHSCtFMnRHNHBaS01QMjJWWXZCdTR1L0lW?= =?utf-8?B?S0lXYnUvbzd2MEVWQU5GNE8yZExNZTFGaXNIc29jVFZaUVE3MUs4RWExVUZr?= =?utf-8?B?Z2wyd1MvZ3NBa0xNNW51Q2NrMnNCS1J6TEZnZFRCdFlnRlpkNlZzWTFiZ2tG?= =?utf-8?B?VHNLQ3NHMUNkanNPRDdaLzZwVW1XZXNSZlY5cjhIY2xyZ3VtbXVvMEdiOVcw?= =?utf-8?B?eng2bFNEU0xoRm52RzlmMGVXczdScmMzV0d1bDZNTFdFR2dxREtKbE9QN0w1?= =?utf-8?B?T1BBcmVqMlJDVWkxd3RWMEYzVzlRZmh5clBWMCtEaS8xbThtVy92d2MwRnJK?= =?utf-8?B?dVNWK0JMak1QL0kyQkIyTUxFMHpHOUtIaklKN3B3UFA5aGNod2tDcmN3Rjgw?= =?utf-8?B?ZDRJNlFsb3l0ODdxWkdkaXJ0bUY1VStrQ1YyR3AzbHYzVkk0MzIyVVZNN2RK?= =?utf-8?B?c0FUay9jMDdlWGI2UTZicmQxeFliQnlqT1BRaFBEYXVxM3p1eHowSDN6dFo4?= =?utf-8?B?RlArNkpqOGgrV3BjYjhTemFSQldWS2J3SEtzNzRoRGNWajVLSTYvT1pUUXA5?= =?utf-8?B?ZXN4cXBhYU1vdHpFdVNCemxjZ21FUUhrRHByQWNzM0o0V0lQd09mVDJSRFdl?= =?utf-8?B?NVNmR0preUVUNG5XWlV2OVRaNjI3Snh5VkllMVZHdy90ekxZOE1JWjVBaFZE?= =?utf-8?B?czNjcWp1QU1OYW4zYkZoNTFDc250YkhyeXdsb0piRTN1MkVzR1Rzc0VQeU5D?= =?utf-8?B?QkVKM3dLZm93K2dXdE5XRnZqQms5djM0RGx5UTJnd1J4NkdaWnBTTUxMZmtm?= =?utf-8?B?enVuNjVoSjJMS1hTWXFRZUVxbkxVeTlHYUxGRlFuQXdzeU8wNEdrODVTMlNU?= =?utf-8?B?bzZ2MU9PQUhZdzA5RW51UEd3SlpINVl6ay9DS0hrUFhEalgvcE9XN3dkMG8y?= =?utf-8?B?Q3h6dmErSWhwL0RPRGhEK3BjNlJpUDIzeFN5czVGRTFNMUpxL0xWZmR6SWxZ?= =?utf-8?B?Q0JYazBPckoyOGR1aE9xSWFqM1JZOHdiRm16MndobmVOQkYwTlJCWk1JVFlW?= =?utf-8?Q?8K0cu6GfJ+gBm600mKEgAxhKg/bAIhh77pErRvt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3b28e35-4a37-40c6-b4b0-08d98f4c108a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 19:51:50.9186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 30I+kFjiWIEOdwyzO0RGOzR2AeDakZ3dij+ktHTWei56XS7bKBJiE1JvxRcj2JbrPWZ4TUkBxLv+OU8MIR4Y3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4590 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/14/21 12:08 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:45AM -0500, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cee86130b95964399c70b08d98ee17462%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637697921262987036%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IkLqCEO9p%2FZxx4ryumEZzBvn8DCR%2Byxl%2Fd%2BdS5dqqbs%3D&reserved=0 >> >> The OvmfPkgX86 build reserves memory regions in MEMFD. The memory regions >> get accessed in the SEC phase. AMD SEV-SNP require that the guest's >> private memory be accepted or validated before access. >> >> Introduce a Guided metadata structure that describes the reserved memory >> regions. The VMM can locate the metadata structure by iterating through >> the reset vector guid and process the areas based on the platform >> specific requirements. > Acked-by: Gerd Hoffmann > > (does it make sense to migrate over the existing SEV_FW_HASH_BLOCK_BASE > and SEV_LAUNCH_SECRET_BASE blocks?) I don't see a strong reason t move over unless someone else sees a real need for it. We anyway have to maintain the backward compatibility because older qemu will look for those region through other GUID.