From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C63BCAC1128 for ; Wed, 25 Oct 2023 09:31:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rKI0NQ+FG4xBKFfXwtNGS7EirvD/qhLtgZ8rISuGc8Y=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698226292; v=1; b=tJBCmwIt2lWWlyHbPzcDYRbVZNW8Fm9J1VCzrTA82+v8vE7nNpjQyH/e22C2ArTyvwLg5l3s zwth8TJIkV0mnWMJ8685WzcmwZxq3cq/VdoZGGBU9rlktlmTWpq1m5U2UuvHOPLVM5wDs93IuOL hekf+mDxaNo1E2r09vOO3Uhg= X-Received: by 127.0.0.2 with SMTP id 3TXYYY7687511x9SOcJkLegN; Wed, 25 Oct 2023 02:31:32 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.169523.1698226286545681637 for ; Wed, 25 Oct 2023 02:31:26 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-fmgWeyEJO8iXOprnXew4sg-1; Wed, 25 Oct 2023 05:31:22 -0400 X-MC-Unique: fmgWeyEJO8iXOprnXew4sg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9B0E185A780; Wed, 25 Oct 2023 09:31:21 +0000 (UTC) X-Received: from [10.39.192.250] (unknown [10.39.192.250]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C20E51121319; Wed, 25 Oct 2023 09:31:19 +0000 (UTC) Message-ID: <72e98a73-51ab-6049-b9ff-1b539c61322a@redhat.com> Date: Wed, 25 Oct 2023 11:31:18 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB To: "Xie, Yuanhao" Cc: "Chiu, Chasel" , "Desimone, Nathaniel L" , Isaac Oram , "Gao, Liming" , "Dong, Eric" , "devel@edk2.groups.io" References: <20231019032010.154-1-yuanhao.xie@intel.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dB7ZVqgmHWK5leLooNfpDgjfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tJBCmwIt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/25/23 10:37, Xie, Yuanhao wrote: > Hi Laszlo, >=20 > I searched for my name to find the patch, and did not find a numbered tag= associated with the patch title, and overlook the comment. I'm sorry for t= he ignoring and inconvenience this have caused. Could you please help with = reverting the patch? I will submit Version 2.=20 I don't see much benefit in a revert at this point; the point would have been to avoid a patch subject in the git commit history that's too generic. But the history is already there at this point (we can't rewrite it -- we can't rebase a public branch), and the code is alright per review, so a revert won't help much here. Laszlo >=20 > Yuanhao > -----Original Message----- > From: Laszlo Ersek =20 > Sent: Wednesday, October 25, 2023 4:00 PM > To: devel@edk2.groups.io; Xie, Yuanhao > Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Isaac Oram ; Gao, Liming <= gaoliming@byosoft.com.cn>; Dong, Eric > Subject: Re: [edk2-devel] [PATCH] Remove memory cache setting for memory = under 1MB >=20 > Yuanhao, >=20 > On 10/19/23 05:20, Yuanhao Xie wrote: >> With the fact that CSM is not supported, the request is to remove the=20 >> cache setting for memory under 1MB. >> This can be treated as the missing part of legacy CSM deprecation. >> >> This patch only set the 00000 to 9FFFF and C0000 to FFFFF as Write Back. >> A0000-BFFFF range is still uncacheable for VGA. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Isaac Oram >> Cc: Liming Gao >> Cc: Eric Dong >> Signed-off-by: Yuanhao Xie >> --- >> =20 >> Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib. >> c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git=20 >> a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi >> b.c=20 >> b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi >> b.c >> index 05728275a5..38a8db6b3f 100644 >> ---=20 >> a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi >> b.c >> +++ b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMt >> +++ rrLib.c >> @@ -245,7 +245,7 @@ SetCacheMtrrAfterEndOfPei ( >> &MtrrSetting, >> 0xC0000, >> 0x40000, >> - CacheWriteProtected >> + CacheWriteBack >> ); >> ASSERT_EFI_ERROR ( Status); >> =20 >=20 > I find that this patch has been pushed as commit 474b81190261. >=20 > Previously, I commented that the subject line of the patch was incorrect,= because it didn't name MinPlatformPkg: >=20 > https://edk2.groups.io/g/devel/message/109747 >=20 > What was your reason for ignoring my comment? >=20 > Laszlo >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110027): https://edk2.groups.io/g/devel/message/110027 Mute This Topic: https://groups.io/mt/102037244/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-