public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Charles Hyde" <chip.programmer@att.net>
To: <devel@edk2.groups.io>
Subject: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c
Date: Sat, 24 Feb 2024 11:01:02 -0500	[thread overview]
Message-ID: <73061DCB4B4D46209875F9B9B0F87C84@DESKTOPQUG2G9K> (raw)
In-Reply-To: 73061DCB4B4D46209875F9B9B0F87C84.ref@DESKTOPQUG2G9K

There is a bug in the following source file:

uefi-sct\
   SctPkg\
      TestCase\
         UEFI\
            EFI\
               Protocol\
                  DevicePathFromText\
                     BlackBoxTest\
                        DevicePathFromTextBBTestCoverage.c


Lines 1737, 1738, 1742, and 1743 reference DNS without any cast override, 
which causes the pointer reference logic to be wrong, leading the functions 
SctStrToIPv4Addr and SctStrToIPv6Addr to cause memory corruption.  The DNS 
reference needs to have (UINT8 *) cast override, like is done in 
DevicePathToTextBBTestMain.c.

Regards,
Chip 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115906): https://edk2.groups.io/g/devel/message/115906
Mute This Topic: https://groups.io/mt/104548292/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



       reply	other threads:[~2024-02-24 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <73061DCB4B4D46209875F9B9B0F87C84.ref@DESKTOPQUG2G9K>
2024-02-24 16:01 ` Charles Hyde [this message]
2024-02-25 15:01   ` [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73061DCB4B4D46209875F9B9B0F87C84@DESKTOPQUG2G9K \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox