From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7C24C940D1A for ; Thu, 22 Feb 2024 00:30:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D4P3/Cc80axjdWhxBKswXYGXACK1UiiHCjEOA0HE+uI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708561829; v=1; b=mQG31+a2CxhmQskFIxZ2JXBStgbwzmt+F2Tp4bwUPC5K5cO6ZFAXliwzir4ifkQVn11k+SpP fYUbmPIAuhvDbnJ2QpgrA+wbndC5n94icmk08LBvPBRxp7clUo867CFNygDGj+p3pO7f05YB2jJ fP5KTzMd66FkYr1FinMOMcKk= X-Received: by 127.0.0.2 with SMTP id xD5hYY7687511xuKZyEsa4Tt; Wed, 21 Feb 2024 16:30:29 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.2324.1708561828345118557 for ; Wed, 21 Feb 2024 16:30:28 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-abR6ksx2NxuONjLJrbefnQ-1; Wed, 21 Feb 2024 19:30:22 -0500 X-MC-Unique: abR6ksx2NxuONjLJrbefnQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17ED91C05ABB; Thu, 22 Feb 2024 00:30:22 +0000 (UTC) X-Received: from [10.39.192.46] (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED064C1596E; Thu, 22 Feb 2024 00:30:20 +0000 (UTC) Message-ID: <730d486f-e0cf-92fe-d088-4c2ca3bdedd0@redhat.com> Date: Thu, 22 Feb 2024 01:30:19 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob To: devel@edk2.groups.io, ray.ni@intel.com, Gerd Hoffmann Cc: Oliver Steffen , "Kumar, Rahul R" References: <20240220174939.1288689-1-kraxel@redhat.com> <20240220174939.1288689-2-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dO2jf20RdUC7RPjWcsuAWbocx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mQG31+a2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/21/24 04:35, Ni, Ray wrote: >> -----Original Message----- >> From: Gerd Hoffmann >> Sent: Wednesday, February 21, 2024 1:50 AM >> To: devel@edk2.groups.io >> Cc: Oliver Steffen ; Laszlo Ersek >> ; Kumar, Rahul R ; Ni, Ray >> ; Gerd Hoffmann >> Subject: [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add support for multiple >> HOBs to GetMpHandOffHob >> >> Rename the function to GetNextMpHandOffHob(), add MP_HAND_OFF >> parameter. >> When called with NULL pointer return the first HOB, otherwise return the >> next in the chain. >> >> Also add the function prototype to the MpLib.h header file. >> >> Signed-off-by: Gerd Hoffmann >> --- >> UefiCpuPkg/Library/MpInitLib/MpLib.h | 12 ++++++++++++ >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 26 ++++++++++++++++---------- >> 2 files changed, 28 insertions(+), 10 deletions(-) >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h >> b/UefiCpuPkg/Library/MpInitLib/MpLib.h >> index a96a6389c17d..bc2a0232291d 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h >> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h >> @@ -485,6 +485,18 @@ SwitchApContext ( >> IN MP_HAND_OFF *MpHandOff >> ); >> >> +/** >> + Get pointer to next MP_HAND_OFF GUIDed HOB. >> + >> + @param[in] MpHandOff Previous HOB. Pass NULL to get the first >> HOB. >=20 > Can you please emphasize in above comments that MpHandOff points to the G= UIDed HOB data? > The function implementation assumes that. +1; had the same observation. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115761): https://edk2.groups.io/g/devel/message/115761 Mute This Topic: https://groups.io/mt/104472308/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-