From: "Laszlo Ersek" <lersek@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH 2/2] OvmfPkg/OvmfXen: Introduce XenDebugLibIoPort
Date: Wed, 22 Apr 2020 18:10:45 +0200 [thread overview]
Message-ID: <732767bc-5bba-37e2-5c2a-90d1ac0e6b21@redhat.com> (raw)
In-Reply-To: <20200422101819.GP4088@perard.uk.xensource.com>
On 04/22/20 12:18, Anthony PERARD wrote:
> On Tue, Apr 21, 2020 at 03:54:26PM +0200, Laszlo Ersek wrote:
>> (2) Please write a patch for the following:
>>
>> - move the PlatformDebugLibIoPortDetect() function definition to a
>> separate file called "DebugIoPortQemu.c",
>
> On this new file, should I copy the copyright lines from DebugLib.c or
> should I add a new copyright line?
Both -- copy the old (C) notices, and add your own too, at the top.
> The rest sounds good, I'll prepare all the patches.
Thank you, I'm relieved you are OK with the request!
Laszlo
prev parent reply other threads:[~2020-04-22 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:29 [PATCH 0/2] OvmfXen: Cleanup debug options Anthony PERARD
2020-04-20 16:29 ` [PATCH 1/2] OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT Anthony PERARD
2020-04-21 13:22 ` Laszlo Ersek
2020-04-20 16:29 ` [PATCH 2/2] OvmfPkg/OvmfXen: Introduce XenDebugLibIoPort Anthony PERARD
2020-04-21 13:54 ` Laszlo Ersek
2020-04-22 10:18 ` Anthony PERARD
2020-04-22 16:10 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732767bc-5bba-37e2-5c2a-90d1ac0e6b21@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox