From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web10.5521.1587571853276686244
 for <devel@edk2.groups.io>;
 Wed, 22 Apr 2020 09:10:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SCAUw5ds;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1587571852;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tiVfMkAtQo10CUnHVUTKohvVE8au1XYTrHuluLnJIdU=;
	b=SCAUw5dsSfUUtaideEfjHIeBSNhBrpXPbxY87loPMTxh95Xg8O/OYByqYSFOe7GmBvLEvg
	hZuVlDhnwBGf/fI5ob2hFtrNGulBUUduMa2zWVS8XzB1W3oFwdhNIMOp+djP5UrNZ352no
	7gwuW/pvHlpA2kTziEEwD+QH7ORjTvM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-165-u75uVrL4OQuprW3Cyv05ZQ-1; Wed, 22 Apr 2020 12:10:48 -0400
X-MC-Unique: u75uVrL4OQuprW3Cyv05ZQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38206DB62;
	Wed, 22 Apr 2020 16:10:47 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 003E860F82;
	Wed, 22 Apr 2020 16:10:45 +0000 (UTC)
Subject: Re: [PATCH 2/2] OvmfPkg/OvmfXen: Introduce XenDebugLibIoPort
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Julien Grall <julien@xen.org>
References: <20200420162918.2312514-1-anthony.perard@citrix.com>
 <20200420162918.2312514-3-anthony.perard@citrix.com>
 <fb0fc9ed-eb03-8b30-57a7-fde17f7e20f6@redhat.com>
 <20200422101819.GP4088@perard.uk.xensource.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <732767bc-5bba-37e2-5c2a-90d1ac0e6b21@redhat.com>
Date: Wed, 22 Apr 2020 18:10:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200422101819.GP4088@perard.uk.xensource.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/22/20 12:18, Anthony PERARD wrote:
> On Tue, Apr 21, 2020 at 03:54:26PM +0200, Laszlo Ersek wrote:
>> (2) Please write a patch for the following:
>>
>> - move the PlatformDebugLibIoPortDetect() function definition to a
>> separate file called "DebugIoPortQemu.c",
> 
> On this new file, should I copy the copyright lines from DebugLib.c or
> should I add a new copyright line?

Both -- copy the old (C) notices, and add your own too, at the top.

> The rest sounds good, I'll prepare all the patches.

Thank you, I'm relieved you are OK with the request!
Laszlo