From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE8E481F37 for ; Thu, 9 Feb 2017 19:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1486697515; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G1q0eg2QR+WgFtaxYQld5YRbRJAXOQk7hSRU9sexaV4=; b=Dx7VuNLlNHH4VXsMkEH5v2uFdTeLVmLsajbnoS6tP064zRwFIIeAYNG73VUrU1E1 UkDXtrLmguxUG/w2qs+Z9FP+fB9QFyGsy9HlLeJccFm4Hr6tNTcfttKUmQe14bxT iokK7fOZOE/0G0I45PbRioDKFUtB+c5ZAEP2y5e95YrlCsv/wqw7W6ZijroNpbTY 4INjtk1+5sffWMXM81mGvNqhSU8lX2RqEaQBvdNWCSxeZ+/zCts7tahQeIaNsfdh jQWHruaf8y7TbIQrxqbo7djJaWr4XVZ127p8Q6NzwQZOqcE9RgpL/uD7/+531E+p LrkO5nmIEzX/BYt+01dybA==; Received: from relay4.apple.com (relay4.apple.com [17.128.113.87]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id E4.9B.14588.B243D985; Thu, 9 Feb 2017 19:31:55 -0800 (PST) X-AuditID: 11973e16-fa0ae9a0000038fc-0a-589d342bff8a Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by relay4.apple.com (Apple SCV relay) with SMTP id CB.75.29672.B243D985; Thu, 9 Feb 2017 19:31:55 -0800 (PST) MIME-version: 1.0 Received: from [17.168.154.176] (unknown [17.168.154.176]) by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.2.0 64bit (built Dec 14 2016)) with ESMTPSA id <0OL500LX73412I00@ma1-mmpp-sz10.apple.com> for edk2-devel@lists.01.org; Thu, 09 Feb 2017 19:31:54 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: <734C28CD-1707-4053-89B8-3747FEB7017D@apple.com> Date: Thu, 09 Feb 2017 19:31:09 -0800 To: edk2-devel X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsUi2FAYrqttMjfCoHOvqsWeQ0eZHRg9umf/ YwlgjOKySUnNySxLLdK3S+DKaLwjXPD/A2PF37UfmBsYH9xi7GLk5JAQMJG4uW4SO4gtJLCX UeLL3iiY+Ponk4BquIDihxglZuxsYgNJ8AoISvyYfI8FxGYWCJN4evk3C0TRCiaJzx9XM4Mk hAXEJd6d2QRmswkoS6yY/4EdIu4nsat7DTvEIBuJq/vmgV3BIqAqsfHxFyYQW0RAQ2JrdytQ LwfQFbISs395gcyXEPjKKvG77QjrBEb+WUjumIXkDghbS+L7o1YgmwPIlpc4eF4WIqwp8eze J3YIW1viybsLrAsY2VYxCuUmZuboZuaZ6yUWFOSk6iXn525iBIXrdDuxHYwPV1kdYhTgYFTi 4Z1QNSdCiDWxrLgy9xCjNAeLkjjvQsm5EUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYUzhl ju0/rJAY/Sb8oIjd34/SHqus7r04lbhu6bJ3q77x1CtktQnO8H5/xsDuyublhi23tRVjHQXY 5xe+v2IvdnCjS6LBvqVXLz+pivskczP1afAyr856KZPyjwr31z2qmPQ5v/yJ8slX05a1J9Q4 B01a+3CRhPvNo5vnrl1ocGL5pX22Omy29UosxRmJhlrMRcWJABaLQFE4AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsUiuLphmq62ydwIg6Yp0hZ7Dh1ldmD06J79 jyWAMYrLJiU1J7MstUjfLoEro/GOcMH/D4wVf9d+YG5gfHCLsYuRk0NCwERi/ZNJULaYxIV7 69m6GLk4hAQOMUrM2NnEBpLgFRCU+DH5HguIzSwQJvH08m8WiKIVTBKfP65mBkkIC4hLvDuz CcxmE1CWWDH/AztE3E9iV/cadohBNhJX980D28YioCqx8fEXJhBbREBDYmt3K1AvB9AVshKz f3lNYOSdhWT1LCSrIWwtie+PWoFsDiBbXuLgeVmIsKbEs3uf2CFsbYkn7y6wLmBkW8UoUJSa k1hpopdYUJCTqpecn7uJERR4DYXhOxj/LbM6xCjAwajEwzuhak6EEGtiWXFlLtD/HMxKIry5 UnMjhHhTEiurUovy44tKc1KLDzFKc7AoifN67p8RISSQnliSmp2aWpBaBJNl4uCUamC81TEt QWZN8fYnzU//fSqcG6P4dBHf5mzmlKqtXseiGhSmps/03DvF5se5DIOE+dria4pf1z60nXVH nsPla/8PsT831/msEso4o/Yywkpb8VPt1Jips9Nsq5ek/3jjtJ0vpcHqjw+TmT6P/vtPHpe2 V/wXFL23RoOf58eyL207b53YnON3L/eBEktxRqKhFnNRcSIAN/AIBjgCAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Should we add PCI VenderId defines to the PCI Includes in the MdePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 03:31:56 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT Some one was asking me why the PCI VendorIds are not included in the MdePkg and my answer was it seems like a good idea to me. We don't have to go crazy as we only really need the VendorIds for vendors who make things that EFI deals with. It is probably easy enough to get an initial list, and then just add values on request. Looks like a bit of duplication is already in the tree... (master)>git grep -w 0x8086 -- *.h *.c AppPkg/Applications/Python/Python-2.7.10/Objects/unicodetype_db.h:2636: case 0x8086: AppPkg/Applications/Python/Python-2.7.2/Objects/unicodetype_db.h:2636: case 0x8086: CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c:502: (Pci->Hdr.VendorId == 0x8086) DuetPkg/Library/DuetBdsLib/BdsPlatform.c:857: ((IS_PCI_ISA_PDECODE (&Pci)) && (Pci.Hdr.VendorId == 0x8086) && (Pci.Hdr.DeviceId == 0x7110))) { DuetPkg/PciBusNoEnumerationDxe/PciBus.h:222:#define IS_INTEL_ISA_BRIDGE(_p) (IS_CLASS2 (_p, PCI_CLASS_BRIDGE, PCI_CLASS_BRIDGE_ISA_PDECODE) && ((_p)->Hdr.VendorId == 0x8086) && ((_p)->Hdr.DeviceId == 0x7110)) OptionRomPkg/UndiRuntimeDxe/E100b.h:23:#define PCI_VENDOR_ID_INTEL 0x8086 OptionRomPkg/UndiRuntimeDxe/E100b.h:25:#define D100_VENDOR_ID 0x8086 OptionRomPkg/UndiRuntimeDxe/Init.c:113: than contains a DevicePath, PciIo protocol, Class code of 2, Vendor ID of 0x8086, OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c:72: 0x8086, // UINT16 CompatibleVid OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.h:50:#define V_INTEL_VENDOR_ID 0x8086 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c:848: (Pci->Hdr.VendorId == 0x8086) && PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c:118: Pci.Hdr.VendorId == 0x8086 ) { QuarkPlatformPkg/Feature/Capsule/Library/PlatformFlashAccessLib/SpiFlashDevice.h:181:#define PFAB_CARD_VENDOR_ID 0x8086 QuarkPlatformPkg/Platform/SpiFvbServices/SpiFlashDevice.h:182:#define PFAB_CARD_VENDOR_ID 0x8086 QuarkSocPkg/QuarkNorthCluster/Include/QuarkNcSocId.h:363:#define V_INTEL_VENDOR_ID 0x8086 QuarkSocPkg/QuarkSouthCluster/Include/Ioh.h:69:#define INTEL_VENDOR_ID 0x8086 // Intel Vendor ID Vlv2DeviceRefCodePkg/ValleyView2Soc/NorthCluster/Include/Valleyview.h:39:#define MC_VID 0x8086 Vlv2DeviceRefCodePkg/ValleyView2Soc/NorthCluster/Include/Valleyview.h:52:#define IGD_VID 0x8086 Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/PchRegs.h:119:#define V_PCH_INTEL_VENDOR_ID 0x8086 Vlv2TbltDevicePkg/Include/CommonIncludes.h:24:#define V_INTEL_VID 0x8086 Vlv2TbltDevicePkg/Include/Platform.h:136:#define V_DEFAULT_SUBSYSTEM_VENDOR_ID 0x8086 Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:24:#define SUBSYSTEM_VENDOR_ID1 0x8086 Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:28:#define SUBSYSTEM_VENDOR_ID2 0x8086 Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:32:#define SUBSYSTEM_VENDOR_ID 0x8086 Vlv2TbltDevicePkg/PciPlatform/BoardPciPlatform.c:30:#define V_INTEL_LAN_VENDOR_ID 0x8086 // INTEL 82574 Gbe Controller Vendor ID Vlv2TbltDevicePkg/PlatformDxe/PciDevice.c:42:#define INTEL_VENDOR_ID 0x8086 Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.h:134: UINT16 VendorId; // 0x8086 Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.h:61:#define IGD_VID 0x8086 Vlv2TbltDevicePkg/Wpce791/LpcDriver.c:194: Pci.Hdr.VendorId == 0x8086 && Thanks, Andrew Fish