Re: [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Thursday, August 11, 2016 1:33 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Chan, Amy <amy.chan@intel.com>
> Subject: Re: [edk2] [PATCH 11/11]
> MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific
> 
> On 2016-08-09 22:56:11, Ruiyu Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Feng Tian <feng.tian@intel.com>
> > Cc: Amy Chan <amy.chan@intel.com>
> > ---
> >  MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 14
> > +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > index aa1ca16..f61e65e 100644
> > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > +++
> b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > @@ -1,7 +1,7 @@
> >  /** @file
> >    Reset Architectural Protocol implementation
> >
> > -  Copyright (c) 2006 - 2012, Intel Corporation. All rights
> > reserved.<BR>
> > +  Copyright (c) 2006 - 2016, Intel Corporation. All rights
> > + reserved.<BR>
> >
> >    This program and the accompanying materials
> >    are licensed and made available under the terms and conditions of
> > the BSD License @@ -86,11 +86,15 @@ DoS3 (
> >
> >    @param[in] ResetType          The type of reset to perform.
> >    @param[in] ResetStatus        The status code for the reset.
> > -  @param[in] DataSize           The size, in bytes, of WatchdogData.
> > +  @param[in] DataSize           The size, in bytes, of ResetData.
> >    @param[in] ResetData          For a ResetType of EfiResetCold,
> EfiResetWarm, or
> >                                  EfiResetShutdown the data buffer starts with a Null-
> terminated
> >                                  string, optionally followed by additional binary data.
> > -
> > +                                The string is a description that the caller may use to
> further
> > +                                indicate the reason for the system reset. ResetData is only
> > +                                valid if ResetStatus is something other than EFI_SUCCESS
> > +                                unless the ResetType is EfiResetPlatformSpecific
> > +                                where a minimum amount of ResetData is always
> required.
> 
> Most of the patches in this series have lines that are longer than 80 columns.
> Can you fix that?

Do we have rule to limit the line to 80 columns? I saw many files have long
lines.
Or I can change OvmfPkg changes to follow the 80 rule. What do you think?

> 
> I think you should move patch 11 before patch 09 "OvmfPkg: Use
> MdeModulePkg/ResetSystemRuntimeDxe". I think this should allow reset to
> continue working through the entire series for OVMF. (right?)

Reset works using my current order.
But I agree moving #11 before #9 can move ResetPlatformSpecific support
earilier, and group the ResetPlatformSpecific patches together. I will do that.

> 
> With those changes,
> 
> Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >  **/
> >  VOID
> >  EFIAPI
> > @@ -144,6 +148,10 @@ ResetSystem (
> >      ResetShutdown ();
> >      return ;
> >
> > +  case EfiResetPlatformSpecific:
> > +    ResetPlatformSpecific (DataSize, ResetData);
> > +    return;
> > +
> >    default:
> >      return ;
> >    }
> > --
> > 2.9.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel