From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ml01.01.org (Postfix) with ESMTP id C3AE91A1DED for ; Wed, 10 Aug 2016 19:43:06 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 10 Aug 2016 19:43:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,503,1464678000"; d="scan'208";a="863434337" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 10 Aug 2016 19:43:06 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 19:43:06 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 19:43:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Thu, 11 Aug 2016 10:43:03 +0800 From: "Ni, Ruiyu" To: "Justen, Jordan L" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Chan, Amy" Thread-Topic: [edk2] [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific Thread-Index: AQHR8swCQvkOkiDnw0etuY3tCnYj26BB7sgAgAEdJWA= Date: Thu, 11 Aug 2016 02:43:03 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D1ADB687A@SHSMSX103.ccr.corp.intel.com> References: <20160810055611.266232-1-ruiyu.ni@intel.com> <20160810055611.266232-12-ruiyu.ni@intel.com> <147085038216.19680.17963102819835257407@jljusten-ivb> In-Reply-To: <147085038216.19680.17963102819835257407@jljusten-ivb> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 02:43:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, August 11, 2016 1:33 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Chan, Amy > Subject: Re: [edk2] [PATCH 11/11] > MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific >=20 > On 2016-08-09 22:56:11, Ruiyu Ni wrote: > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ruiyu Ni > > Cc: Feng Tian > > Cc: Amy Chan > > --- > > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 14 > > +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git > > a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > index aa1ca16..f61e65e 100644 > > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > +++ > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > @@ -1,7 +1,7 @@ > > /** @file > > Reset Architectural Protocol implementation > > > > - Copyright (c) 2006 - 2012, Intel Corporation. All rights > > reserved.
> > + Copyright (c) 2006 - 2016, Intel Corporation. All rights > > + reserved.
> > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of > > the BSD License @@ -86,11 +86,15 @@ DoS3 ( > > > > @param[in] ResetType The type of reset to perform. > > @param[in] ResetStatus The status code for the reset. > > - @param[in] DataSize The size, in bytes, of WatchdogData. > > + @param[in] DataSize The size, in bytes, of ResetData. > > @param[in] ResetData For a ResetType of EfiResetCold, > EfiResetWarm, or > > EfiResetShutdown the data buffer start= s with a Null- > terminated > > string, optionally followed by additio= nal binary data. > > - > > + The string is a description that the c= aller may use to > further > > + indicate the reason for the system res= et. ResetData is only > > + valid if ResetStatus is something othe= r than EFI_SUCCESS > > + unless the ResetType is EfiResetPlatfo= rmSpecific > > + where a minimum amount of ResetData is= always > required. >=20 > Most of the patches in this series have lines that are longer than 80 col= umns. > Can you fix that? Do we have rule to limit the line to 80 columns? I saw many files have long lines. Or I can change OvmfPkg changes to follow the 80 rule. What do you think? >=20 > I think you should move patch 11 before patch 09 "OvmfPkg: Use > MdeModulePkg/ResetSystemRuntimeDxe". I think this should allow reset to > continue working through the entire series for OVMF. (right?) Reset works using my current order. But I agree moving #11 before #9 can move ResetPlatformSpecific support earilier, and group the ResetPlatformSpecific patches together. I will do t= hat. >=20 > With those changes, >=20 > Series Reviewed-by: Jordan Justen >=20 > > **/ > > VOID > > EFIAPI > > @@ -144,6 +148,10 @@ ResetSystem ( > > ResetShutdown (); > > return ; > > > > + case EfiResetPlatformSpecific: > > + ResetPlatformSpecific (DataSize, ResetData); > > + return; > > + > > default: > > return ; > > } > > -- > > 2.9.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel