From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 86ACB1A1E12 for ; Mon, 22 Aug 2016 21:56:47 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 22 Aug 2016 21:56:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,564,1464678000"; d="scan'208";a="1018840942" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 22 Aug 2016 21:56:47 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 22 Aug 2016 21:56:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002; Tue, 23 Aug 2016 12:56:44 +0800 From: "Ni, Ruiyu" To: "Tian, Feng" , "edk2-devel@lists.01.org" CC: "Chan, Amy" Thread-Topic: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Thread-Index: AQHR/O16bIwIltndOEehML+xpa5JtKBV4asQ Date: Tue, 23 Aug 2016 04:56:44 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D1ADBF868@SHSMSX103.ccr.corp.intel.com> References: <20160810055611.266232-1-ruiyu.ni@intel.com> <20160810055611.266232-4-ruiyu.ni@intel.com> <7F1BAD85ADEA444D97065A60D2E97EE538824F50@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE538824F50@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 04:56:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Feng, The spec says " If the platform does not recognize the EFI_GUID in ResetDat= a the platform must pick a supported reset type to perform". For the NULL instance of ResetSystemLib, I treat it as an implementation fo= r a Certain platform, then it's ok to let it pick a supported reset type to per= form. Thanks/Ray > -----Original Message----- > From: Tian, Feng > Sent: Tuesday, August 23, 2016 11:22 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chan, Amy ; Tian, Feng > Subject: RE: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: > Implement ResetPlatformSpecific >=20 > Do you need directly assert in ResetPlatformSpecific() for this NULL inst= ance? > Other series look good to me >=20 > Reviewed-by: Feng Tian >=20 > Thanks > Feng >=20 > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, August 10, 2016 1:56 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Chan, Amy > Subject: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: > Implement ResetPlatformSpecific >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Feng Tian > Cc: Amy Chan > --- > .../BaseResetSystemLibNull.c | 23 ++++++++++++++++= +++++- > 1 file changed, 22 insertions(+), 1 deletion(-) >=20 > diff --git > a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul > l.c > b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul > l.c > index d21a774..b233254 100644 > --- > a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul > l.c > +++ > b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul > l > +++ .c > @@ -1,7 +1,7 @@ > /** @file > Null Reset System Library instance that only generates ASSERT() condit= ions. >=20 > - Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2016, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at @@ -77,3 +77,24 @@ EnterS3WithImmediateWake ( { > ASSERT (FALSE); > } > + > +/** > + This function causes a systemwide reset. The exact type of the reset > +is defined > + by the EFI_GUID that follows the Null-terminated Unicode string passed > into ResetData. > + If the platform does not recognize the EFI_GUID in ResetData the > +platform must pick a > + supported reset type to perform.The platform may optionally log the > +parameters from > + any non-normal reset that occurs. > + > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData The data buffer starts with a Null-terminated > string, followed > + by the EFI_GUID. > +**/ > +VOID > +EFIAPI > +ResetPlatformSpecific ( > + IN UINTN DataSize, > + IN VOID *ResetData > + ) > +{ > + ResetCold (); > +} > -- > 2.9.0.windows.1