* [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex
@ 2016-08-26 9:41 Star Zeng
2016-08-31 7:08 ` Ni, Ruiyu
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2016-08-26 9:41 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Ruiyu Ni
UEFI spec:
Each load option entry resides in a Boot####, Driver####, SysPrep####,
OsRecovery#### or PlatformRecovery#### variable where #### is replaced
by a unique option number in printable hexadecimal representation using
the digits 0-9, and the upper case versions of the characters A-F
(0000-FFFF).
The patch also makes L"HwErrRec####" follow this rule.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Library/VarCheckLib/VarCheckLib.c | 16 ++++++++--------
.../Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 14 +++++++-------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
index 41b209da169f..5ca0d3edca44 100644
--- a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
+++ b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
@@ -1,7 +1,7 @@
/** @file
Implementation functions and structures for var check services.
-Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -96,17 +96,17 @@ VARIABLE_ENTRY_PROPERTY mVarCheckVariableWithWildcardName[] = {
};
/**
- Check if a Unicode character is a hexadecimal character.
+ Check if a Unicode character is an upper case hexadecimal character.
- This function checks if a Unicode character is a
- hexadecimal character. The valid hexadecimal character is
- L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
+ This function checks if a Unicode character is an upper case
+ hexadecimal character. The valid upper case hexadecimal character is
+ L'0' to L'9', or L'A' to L'F'.
@param[in] Char The character to check against.
- @retval TRUE If the Char is a hexadecmial character.
- @retval FALSE If the Char is not a hexadecmial character.
+ @retval TRUE If the Char is an upper case hexadecmial character.
+ @retval FALSE If the Char is not an upper case hexadecmial character.
**/
BOOLEAN
@@ -115,7 +115,7 @@ VarCheckInternalIsHexaDecimalDigitCharacter (
IN CHAR16 Char
)
{
- return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char <= L'F') || (Char >= L'a' && Char <= L'f'));
+ return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char <= L'F'));
}
/**
diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
index 8f7126e6aea6..80dc6341adcf 100644
--- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
+++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
@@ -678,17 +678,17 @@ EFI_GUID *mUefiDefinedGuid[] = {
};
/**
- Check if a Unicode character is a hexadecimal character.
+ Check if a Unicode character is an upper case hexadecimal character.
- This function checks if a Unicode character is a
- hexadecimal character. The valid hexadecimal character is
- L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
+ This function checks if a Unicode character is an upper case
+ hexadecimal character. The valid upper case hexadecimal character is
+ L'0' to L'9', or L'A' to L'F'.
@param[in] Char The character to check against.
- @retval TRUE If the Char is a hexadecmial character.
- @retval FALSE If the Char is not a hexadecmial character.
+ @retval TRUE If the Char is an upper case hexadecmial character.
+ @retval FALSE If the Char is not an upper case hexadecmial character.
**/
BOOLEAN
@@ -697,7 +697,7 @@ VarCheckUefiIsHexaDecimalDigitCharacter (
IN CHAR16 Char
)
{
- return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char <= L'F') || (Char >= L'a' && Char <= L'f'));
+ return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char <= L'F'));
}
/**
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex
2016-08-26 9:41 [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex Star Zeng
@ 2016-08-31 7:08 ` Ni, Ruiyu
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2016-08-31 7:08 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Zeng, Star
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, August 26, 2016 5:41 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are
> upper case hex
>
> UEFI spec:
> Each load option entry resides in a Boot####, Driver####, SysPrep####,
> OsRecovery#### or PlatformRecovery#### variable where #### is replaced
> by a unique option number in printable hexadecimal representation using
> the digits 0-9, and the upper case versions of the characters A-F (0000-FFFF).
>
> The patch also makes L"HwErrRec####" follow this rule.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Library/VarCheckLib/VarCheckLib.c | 16 ++++++++-----
> ---
> .../Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 14 +++++++-------
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
> b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
> index 41b209da169f..5ca0d3edca44 100644
> --- a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
> +++ b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.c
> @@ -1,7 +1,7 @@
> /** @file
> Implementation functions and structures for var check services.
>
> -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License which
> accompanies this distribution. The full text of the license may be found at
> @@ -96,17 +96,17 @@ VARIABLE_ENTRY_PROPERTY
> mVarCheckVariableWithWildcardName[] = { };
>
> /**
> - Check if a Unicode character is a hexadecimal character.
> + Check if a Unicode character is an upper case hexadecimal character.
>
> - This function checks if a Unicode character is a
> - hexadecimal character. The valid hexadecimal character is
> - L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
> + This function checks if a Unicode character is an upper case
> + hexadecimal character. The valid upper case hexadecimal character is
> + L'0' to L'9', or L'A' to L'F'.
>
>
> @param[in] Char The character to check against.
>
> - @retval TRUE If the Char is a hexadecmial character.
> - @retval FALSE If the Char is not a hexadecmial character.
> + @retval TRUE If the Char is an upper case hexadecmial character.
> + @retval FALSE If the Char is not an upper case hexadecmial character.
>
> **/
> BOOLEAN
> @@ -115,7 +115,7 @@ VarCheckInternalIsHexaDecimalDigitCharacter (
> IN CHAR16 Char
> )
> {
> - return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char
> <= L'F') || (Char >= L'a' && Char <= L'f'));
> + return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' &&
> + Char <= L'F'));
> }
>
> /**
> diff --git
> a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
> b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
> index 8f7126e6aea6..80dc6341adcf 100644
> --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
> +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
> @@ -678,17 +678,17 @@ EFI_GUID *mUefiDefinedGuid[] = { };
>
> /**
> - Check if a Unicode character is a hexadecimal character.
> + Check if a Unicode character is an upper case hexadecimal character.
>
> - This function checks if a Unicode character is a
> - hexadecimal character. The valid hexadecimal character is
> - L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
> + This function checks if a Unicode character is an upper case
> + hexadecimal character. The valid upper case hexadecimal character is
> + L'0' to L'9', or L'A' to L'F'.
>
>
> @param[in] Char The character to check against.
>
> - @retval TRUE If the Char is a hexadecmial character.
> - @retval FALSE If the Char is not a hexadecmial character.
> + @retval TRUE If the Char is an upper case hexadecmial character.
> + @retval FALSE If the Char is not an upper case hexadecmial character.
>
> **/
> BOOLEAN
> @@ -697,7 +697,7 @@ VarCheckUefiIsHexaDecimalDigitCharacter (
> IN CHAR16 Char
> )
> {
> - return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' && Char
> <= L'F') || (Char >= L'a' && Char <= L'f'));
> + return (BOOLEAN) ((Char >= L'0' && Char <= L'9') || (Char >= L'A' &&
> + Char <= L'F'));
> }
>
> /**
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-31 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 9:41 [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex Star Zeng
2016-08-31 7:08 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox