From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C08B1A1E56 for ; Wed, 31 Aug 2016 19:02:56 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP; 31 Aug 2016 19:02:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,264,1470726000"; d="scan'208";a="3372394" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 31 Aug 2016 19:02:56 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 19:02:55 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 19:02:54 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.102]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0248.002; Thu, 1 Sep 2016 10:02:53 +0800 From: "Ni, Ruiyu" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenuApp Thread-Index: AQHSA2BwJCtLHvBgQEi2S9iY41RA5aBj4wrA Date: Thu, 1 Sep 2016 02:02:53 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D58D45B4B@SHSMSX103.ccr.corp.intel.com> References: <1472631570-30580-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1472631570-30580-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenuApp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 02:02:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Please use the term "BootManagerMenu" instead of "BootMenuApp", to avoid co= nfusion when reading from future developers. BmIsBootMenuAppFilePath --> BmIsBootManagerMenuFilePath With the above change,=20 Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, August 31, 2016 4:20 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch] MdeModulePkg UefiBootManagerLib: Rename > BootMenuApp to BootManagerMenuApp >=20 > Rename local function name BootMenuApp to BootManagerMenuApp to > align to other public function name. >=20 > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 20 ++++++++++-- > -------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > index f8a3988..88bb13b 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > @@ -1530,15 +1530,15 @@ EfiBootManagerGetLoadOptionBuffer ( } >=20 > /** > - Check if it's a Device Path pointing to BootMenuApp. > + Check if it's a Device Path pointing to BootManagerMenuApp. >=20 > @param DevicePath Input device path. >=20 > - @retval TRUE The device path is BootMenuApp File Device Path. > - @retval FALSE The device path is NOT BootMenuApp File Device Path. > + @retval TRUE The device path is BootManagerMenuApp File Device Path. > + @retval FALSE The device path is NOT BootManagerMenuApp File Device > Path. > **/ > BOOLEAN > -BmIsBootMenuAppFilePath ( > +BmIsBootManagerMenuAppFilePath ( > EFI_DEVICE_PATH_PROTOCOL *DevicePath > ) > { > @@ -1645,7 +1645,7 @@ EfiBootManagerBoot ( > // 3. Signal the EVT_SIGNAL_READY_TO_BOOT event when we are about to > load and execute > // the boot option. > // > - if (BmIsBootMenuAppFilePath (BootOption->FilePath)) { > + if (BmIsBootManagerMenuAppFilePath (BootOption->FilePath)) { > DEBUG ((EFI_D_INFO, "[Bds] Booting Boot Manager Menu.\n")); > BmStopHotkeyService (NULL, NULL); > } else { > @@ -2070,9 +2070,9 @@ BmEnumerateBootOptions ( > ); > for (Index =3D 0; Index < HandleCount; Index++) { > // > - // Ignore BootMenuApp. its boot option will be created by > BmRegisterBootManagerMenu(). > + // Ignore BootManagerMenuApp. its boot option will be created by > BmRegisterBootManagerMenu(). > // > - if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) > { > + if (BmIsBootManagerMenuAppFilePath (DevicePathFromHandle > + (Handles[Index]))) { > continue; > } >=20 > @@ -2212,7 +2212,7 @@ BmRegisterBootManagerMenu ( > DevicePath =3D NULL; > Description =3D NULL; > // > - // Try to find BootMenuApp from LoadFile protocol > + // Try to find BootManagerMenuApp from LoadFile protocol > // > gBS->LocateHandleBuffer ( > ByProtocol, > @@ -2222,7 +2222,7 @@ BmRegisterBootManagerMenu ( > &Handles > ); > for (Index =3D 0; Index < HandleCount; Index++) { > - if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) > { > + if (BmIsBootManagerMenuAppFilePath (DevicePathFromHandle > + (Handles[Index]))) { > DevicePath =3D DuplicateDevicePath (DevicePathFromHandle > (Handles[Index])); > Description =3D BmGetBootDescription (Handles[Index]); > break; > @@ -2331,7 +2331,7 @@ EfiBootManagerGetBootManagerMenu ( > BootOptions =3D EfiBootManagerGetLoadOptions (&BootOptionCount, > LoadOptionTypeBoot); >=20 > for (Index =3D 0; Index < BootOptionCount; Index++) { > - if (BmIsBootMenuAppFilePath (BootOptions[Index].FilePath)) { > + if (BmIsBootManagerMenuAppFilePath (BootOptions[Index].FilePath)) { > Status =3D EfiBootManagerInitializeLoadOption ( > BootOption, > BootOptions[Index].OptionNumber, > -- > 2.8.0.windows.1