From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Nico.Schulz@ts.fujitsu.com" <Nico.Schulz@ts.fujitsu.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib
Date: Wed, 7 Sep 2016 00:54:44 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58D4DCB9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <b3dba89dd92c4b30a34aee84a1b99009@R01UKEXCASM221.r01.fujitsu.local>
Nico,
You want to develop an application which needs file system access support but doesn't depend on Shell environment. So you link your application to UefiShellLib and change the shell library to handle the case when it's not in the Shell environment.
Is my understanding correct?
If yes, I suggest you directly use MdePkg/Library/UefiFileHandleLib. It provides file system access support while doesn't depend on Shell environment.
It's a bit strange to remove the hard dependency of Shell environment from Uefi*Shell*Lib.
Regards,
Ray
From: Nico.Schulz@ts.fujitsu.com [mailto:Nico.Schulz@ts.fujitsu.com]
Sent: Tuesday, September 6, 2016 8:02 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib
Dear edk2 developers,
I've made a patch in the edk2 ShellPkg CodeModule. It improves compatibility when no Efi Shell is available. I've noted all details on Github. To not duplicate the information, please visit this link below. You can also find and compare the code there:
https://github.com/tianocore/edk2/pull/111
It would be really nice if you can have a look at the patch. Some further discussion might be required before this patch gets applied. Feedback is highly welcome. Thanks a lot :)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Nico Schulz nico.schulz@ts.fujitsu.com<mailto:nico.schulz@ts.fujitsu.com>
Cheers,
Nico
next prev parent reply other threads:[~2016-09-07 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 12:02 [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib Nico.Schulz
2016-09-07 0:54 ` Ni, Ruiyu [this message]
2016-09-08 7:06 ` Nico.Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D58D4DCB9@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox