[PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

[PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

[Nico.Schulz]

Dear edk2 developers,

I’ve made a patch in the edk2 ShellPkg CodeModule. It improves compatibility
when no Efi Shell is available. I’ve noted all details on Github. To not
duplicate the information, please visit this link below. You can also find
and compare the code there:

https://github.com/tianocore/edk2/pull/111

 

It would be really nice if you can have a look at the patch. Some further
discussion might be required before this patch gets applied. Feedback is
highly welcome. Thanks a lot J

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by:  Nico Schulz nico.schulz@ts.fujitsu.com

 

Cheers,

Nico

 

Re: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

[Ni, Ruiyu]

Nico,
You want to develop an application which needs file system access support but doesn't depend on Shell environment. So you link your application to UefiShellLib and change the shell library to handle the case when it's not in the Shell environment.
Is my understanding correct?

If yes, I suggest you directly use MdePkg/Library/UefiFileHandleLib. It provides file system access support while doesn't depend on Shell environment.

It's a bit strange to remove the hard dependency of Shell environment from Uefi*Shell*Lib.

Regards,
Ray

From: Nico.Schulz@ts.fujitsu.com [mailto:Nico.Schulz@ts.fujitsu.com]
Sent: Tuesday, September 6, 2016 8:02 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

Dear edk2 developers,
I've made a patch in the edk2 ShellPkg CodeModule. It improves compatibility when no Efi Shell is available. I've noted all details on Github. To not duplicate the information, please visit this link below. You can also find and compare the code there:
https://github.com/tianocore/edk2/pull/111

It would be really nice if you can have a look at the patch. Some further discussion might be required before this patch gets applied. Feedback is highly welcome. Thanks a lot :)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:  Nico Schulz nico.schulz@ts.fujitsu.com<mailto:nico.schulz@ts.fujitsu.com>

Cheers,
Nico

Re: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

[Nico.Schulz]

Hello Ray,

Thanks for your response. I was not aware of this library, that sounds like
a very good idea.

 

But when having a look at it, there seem to be only file read/write/info
operations. I cannot find a function that would give me a file handle and
open it. Especially for me it needs to be the device where also the program
is running (normally the boot device). Currently I use ShellOpenFileByName()
for this operation. I could not find anything like that, do you know what is
required to get a file handle and open the file properly? Is there any
example that I am missing?

 

Also I am wondering why the ShellPkg library has fallbacks for almost every
function if they are not essentially required. It might make sense to add my
patch anyways to complete the fallbacks. But that is up to you, you should
know it best.

 

Cheers,

Nico

 

 

From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com] 
Sent: Wednesday, September 7, 2016 2:55 AM
To: Schulz, Nico; edk2-devel@lists.01.org
Cc: Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: More fallbacks + error handling in
UefiShellLib

 

Nico,

You want to develop an application which needs file system access support
but doesn’t depend on Shell environment. So you link your application to
UefiShellLib and change the shell library to handle the case when it’s not
in the Shell environment.

Is my understanding correct?

 

If yes, I suggest you directly use MdePkg/Library/UefiFileHandleLib. It
provides file system access support while doesn’t depend on Shell
environment.

 

It’s a bit strange to remove the hard dependency of Shell environment from
Uefi*Shell*Lib.

 

Regards,

Ray

 

From: Nico.Schulz@ts.fujitsu.com [mailto:Nico.Schulz@ts.fujitsu.com] 
Sent: Tuesday, September 6, 2016 8:02 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

 

Dear edk2 developers,

I’ve made a patch in the edk2 ShellPkg CodeModule. It improves compatibility
when no Efi Shell is available. I’ve noted all details on Github. To not
duplicate the information, please visit this link below. You can also find
and compare the code there:

https://github.com/tianocore/edk2/pull/111

 

It would be really nice if you can have a look at the patch. Some further
discussion might be required before this patch gets applied. Feedback is
highly welcome. Thanks a lot J

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by:  Nico Schulz nico.schulz@ts.fujitsu.com

 

Cheers,

Nico