From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] OptionRomPkg: Fix GCC build failure
Date: Sun, 9 Oct 2016 03:14:19 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E15E1C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1474512670-82864-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Pushed as ea79dc2b77d8438f840e85b44a43760337637a6a.
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, September 22, 2016 10:51 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] OptionRomPkg: Fix GCC build failure
>
> Remove the variable which is set but not used to pass GCC build.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> index dd18a95..73d54f0 100644
> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> @@ -665,11 +665,10 @@ FillPkt2Queue (
> UINT16 * pLength;
> UINT16 * pLengthBar;
> UINT8* pData;
> UINT32 offset;
> RX_TX_PACKET * pRxPacket;
> - UINTN LengthInBytes;
> EFI_STATUS Status;
>
> for ( offset = 0; offset < BufLength; ){
> pLength = (UINT16*) (pNicDevice->pBulkInBuff + offset);
> pLengthBar = (UINT16*) (pNicDevice->pBulkInBuff + offset +2); @@ -
> 682,11 +681,10 @@ FillPkt2Queue (
> DEBUG (( EFI_D_ERROR , "Pkt length error. BufLength = %d\n",
> BufLength));
> return;
> }
>
> pRxPacket = pNicDevice->pRxFree;
> - LengthInBytes = sizeof ( *pRxPacket ) - sizeof ( pRxPacket->pNext );
> if ( NULL == pRxPacket ) {
> Status = gBS->AllocatePool ( EfiRuntimeServicesData,
> sizeof( RX_TX_PACKET ),
> (VOID **) &pRxPacket );
> if ( !EFI_ERROR ( Status )) {
> --
> 1.9.5.msysgit.1
prev parent reply other threads:[~2016-10-09 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 2:51 [patch] OptionRomPkg: Fix GCC build failure Dandan Bi
2016-10-09 3:14 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D58E15E1C@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox